From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Arne Caspari <arne@datafloater.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/driver.c : driver_unregister
Date: Sat, 11 Dec 2004 19:11:13 +0000 [thread overview]
Message-ID: <20041211191113.A13985@flint.arm.linux.org.uk> (raw)
In-Reply-To: <41BB4268.8020908@datafloater.de>; from arne@datafloater.de on Sat, Dec 11, 2004 at 07:54:32PM +0100
On Sat, Dec 11, 2004 at 07:54:32PM +0100, Arne Caspari wrote:
> I think the meaning of this patch is obvious: In driver_unregister, the
> bus_remove_driver function call was called outside the driver unload
> semaphore which should obviously protect it.
No. The semaphore is there to ensure that the function does not
return until the driver structure has a use count of zero. If you
tested your patch, you'd find that your change would deadlock on
the locked semaphore.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-12-11 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-11 18:54 [PATCH] drivers/base/driver.c : driver_unregister Arne Caspari
2004-12-11 19:11 ` Russell King [this message]
2004-12-11 19:24 ` Arne Caspari
2004-12-13 7:21 ` Arne Caspari
2004-12-13 21:07 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041211191113.A13985@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=arne@datafloater.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).