From: Andrew Morton <akpm@osdl.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.10-rc3-mm1
Date: Thu, 16 Dec 2004 23:55:05 -0800 [thread overview]
Message-ID: <20041216235505.3eaad88c.akpm@osdl.org> (raw)
In-Reply-To: <20041217025127.GP771@holomorphy.com>
William Lee Irwin III <wli@holomorphy.com> wrote:
>
> William Lee Irwin III <wli@holomorphy.com> wrote:
> >> This appears to have trouble on em64t; not only does the following happen,
> >> but some odd userspace programs (e.g. ssh) appear to be failing.
> >>
> >> Shutting down powersaved cut here ] --------- [please bite here ] ---------
> >> KDdoneernel BUG at pageattr:156
>
> On Wed, Dec 15, 2004 at 03:42:39AM -0800, Andrew Morton wrote:
> > I can't say I'm surprised, really, although it booted and did stuff OK on my
> > box.
> > There's a mangled-up mess of ioremap/pageattr patches from Andrea and Andi
> > in there. I'll drop a few things. We need to go through those changes a
> > little more carefully.
>
> The odd userspace programs failing are far more disturbing. They
> suggest COW or something of similar gravity is broken on x86-64
> by some new patch. The ioremap/pageattr issues are merely some
> shutdown-time oops, which is rather minor in comparison, although
> reported far more verbosely.
Oh, I missed that. Did you apply the ioctl fix?
--- 25/fs/ioctl.c~ioctl-cleanups-broke-fionread-et-al 2004-12-13 11:12:37.687951760 -0800
+++ 25-akpm/fs/ioctl.c 2004-12-13 11:12:37.690951304 -0800
@@ -91,10 +91,8 @@ asmlinkage long sys_ioctl(unsigned int f
int block;
int res;
- if (!S_ISREG(inode->i_mode)) {
- error = -ENOTTY;
- goto done;
- }
+ if (!S_ISREG(inode->i_mode))
+ break;
/* do we support this mess? */
if (!mapping->a_ops->bmap) {
error = -EINVAL;
@@ -112,19 +110,15 @@ asmlinkage long sys_ioctl(unsigned int f
goto done;
}
case FIGETBSZ:
- if (!S_ISREG(inode->i_mode)) {
- error = -ENOTTY;
- goto done;
- }
+ if (!S_ISREG(inode->i_mode))
+ break;
error = -EBADF;
if (inode->i_sb)
error = put_user(inode->i_sb->s_blocksize, p);
goto done;
case FIONREAD:
- if (!S_ISREG(inode->i_mode)) {
- error = -ENOTTY;
- goto done;
- }
+ if (!S_ISREG(inode->i_mode))
+ break;
error = put_user(i_size_read(inode) - filp->f_pos, p);
goto done;
}
_
next prev parent reply other threads:[~2004-12-17 7:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 10:03 2.6.10-rc3-mm1 Andrew Morton
2004-12-13 10:31 ` 2.6.10-rc3-mm1 Kasper Sandberg
2004-12-13 10:36 ` 2.6.10-rc3-mm1 Andrew Morton
2004-12-13 20:27 ` 2.6.10-rc3-mm1 Nigel Cunningham
2004-12-13 12:02 ` 2.6.10-rc3-mm1 Christoph Hellwig
2004-12-13 15:01 ` 2.6.10-rc3-mm1 J.A. Magallon
2004-12-13 16:06 ` 2.6.10-rc3-mm1 Greg KH
2004-12-13 16:15 ` 2.6.10-rc3-mm1 Marcos D. Marado Torres
2004-12-13 17:02 ` 2.6.10-rc3-mm1 Fabio Coatti
2004-12-13 18:10 ` 2.6.10-rc3-mm1 Rudmer van Dijk
2004-12-13 19:33 ` 2.6.10-rc3-mm1 Andrew Morton
2004-12-13 19:49 ` 2.6.10-rc3-mm1 Rudmer van Dijk
2004-12-13 21:06 ` 2.6.10-rc3-mm1 Felipe Alfaro Solana
2004-12-13 20:08 ` 2.6.10-rc3-mm1 Stephen Smalley
2004-12-14 4:10 ` [patch] 2.6.10-rc3-mm1: fix net/tulip/xircom_tulip_cb.c warning Adrian Bunk
2004-12-14 16:04 ` 2.6.10-rc3-mm1 (compile stats) John Cherry
2004-12-15 10:41 ` Paul Rolland
2004-12-15 16:16 ` John Cherry
2004-12-15 11:35 ` 2.6.10-rc3-mm1 William Lee Irwin III
2004-12-15 11:42 ` 2.6.10-rc3-mm1 Andrew Morton
2004-12-17 2:51 ` 2.6.10-rc3-mm1 William Lee Irwin III
2004-12-17 7:55 ` Andrew Morton [this message]
2004-12-17 12:00 ` 2.6.10-rc3-mm1 William Lee Irwin III
2004-12-17 12:18 ` 2.6.10-rc3-mm1 Hugh Dickins
2004-12-16 17:49 ` 2.6.10-rc3-mm1 Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041216235505.3eaad88c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).