From: Horst von Brand <vonbrand@inf.utfsm.cl>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: "Jörn Engel" <joern@wohnheim.fh-wedel.de>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Steve French" <sfrench@samba.org>,
"Steve French" <sfrench@us.ibm.com>,
samba-technical <samba-technical@lists.samba.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/3] whitespace cleanups in fs/cifs/file.c
Date: Wed, 29 Dec 2004 10:42:40 -0300 [thread overview]
Message-ID: <200412291342.iBTDgeKe007858@laptop11.inf.utfsm.cl> (raw)
In-Reply-To: Message from Jesper Juhl <juhl-lkml@dif.dk> of "Wed, 29 Dec 2004 03:59:55 BST." <Pine.LNX.4.61.0412290347020.28589@dragon.hygekrogen.localhost>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Jesper Juhl <juhl-lkml@dif.dk> said:
> On Wed, 29 Dec 2004, Jörn Engel wrote:
>
> > On Wed, 29 December 2004 00:52:32 +0100, Jesper Juhl wrote:
> > > - if(file->private_data != NULL) {
> > > + if (file->private_data != NULL) {
> >
> > if (file->private_data) {
> >
> > It's a question of taste, but in most cases I consider the shorter
> > version to be more obvious.
> >
> Yeah, matter of personal preference, but since both styles are used in the
> file I had to pick one of them to try and make it consistent - I simply
> picked my personally prefered form.
Nope. See Documentation/CodingStyle (it implicitly agrees with you, BTW).
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
next prev parent reply other threads:[~2004-12-29 13:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-26 23:24 [patch] copy_to_user check and whitespace cleanups in fs/cifs/file.c Jesper Juhl
2004-12-26 23:38 ` Alan Cox
2004-12-27 1:21 ` Jesper Juhl
2004-12-28 23:48 ` [patch 1/3] copy_to_user check " Jesper Juhl
2004-12-28 22:45 ` Alan Cox
2004-12-28 23:52 ` [patch 2/3] whitespace cleanups " Jesper Juhl
2004-12-29 1:57 ` Jörn Engel
2004-12-29 2:59 ` Jesper Juhl
2004-12-29 12:29 ` Jörn Engel
2004-12-29 18:48 ` Domen Puncer
2004-12-29 13:42 ` Horst von Brand [this message]
2004-12-29 14:48 ` [patch 2/3] " Jörn Engel
2004-12-29 16:31 ` Horst von Brand
2004-12-29 9:51 ` Wichert Akkerman
2004-12-29 12:10 ` Jörn Engel
2005-01-03 12:01 ` Martin Waitz
2004-12-28 23:55 ` [patch 3/3] get rid of two unnessesary assignments " Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412291342.iBTDgeKe007858@laptop11.inf.utfsm.cl \
--to=vonbrand@inf.utfsm.cl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joern@wohnheim.fh-wedel.de \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).