From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Len Brown <len.brown@intel.com>
Cc: Michael Geithe <warpy@gmx.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: __iounmap: bad address c00f0000 (Re: 2.6.10-bk5)
Date: Mon, 3 Jan 2005 18:02:09 +0000 [thread overview]
Message-ID: <20050103180209.GW26051@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1104774583.18174.68.camel@d845pe>
On Mon, Jan 03, 2005 at 12:49:43PM -0500, Len Brown wrote:
> Suggested-by: Al Viro
> Signed-off-by: Len Brown <len.brown@intel.com>
>
>
> ===== arch/i386/kernel/dmi_scan.c 1.74 vs edited =====
> --- 1.74/arch/i386/kernel/dmi_scan.c 2004-12-28 14:07:48 -05:00
> +++ edited/arch/i386/kernel/dmi_scan.c 2005-01-03 12:46:33 -05:00
> @@ -126,12 +126,12 @@
> dmi_printk((KERN_INFO "DMI table at 0x%08X.\n",
> base));
> if(dmi_table(base,len, num, decode)==0) {
> - iounmap(p);
> + /* too early to call iounmap(p); */
One comment: iounmap() on result of ioremap(ISA address) is a no-op.
The problem in this case is that we are too early in setup sequence
and that confuses iounmap() into not recognizing that fact. So we
end up trying to find VMA created by ioremap() and (surprise, surprise)
find none. Which gives the warning in question. We *still* do nothing,
so everything actually works fine, but we do get confused "WTF is going
on?" in the logs.
next prev parent reply other threads:[~2005-01-03 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 0:14 2.6.10-bk5 Michael Geithe
2005-01-03 17:24 ` __iounmap: bad address c00f0000 (Re: 2.6.10-bk5) Len Brown
2005-01-03 17:49 ` Al Viro
2005-01-03 17:49 ` Len Brown
2005-01-03 18:02 ` Al Viro [this message]
2005-01-03 18:29 ` Michael Geithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050103180209.GW26051@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=warpy@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).