Re: [PATCH] fs: Restore files_lock and set_fs_root exports

[Andrew Morton <akpm@osdl.org>]

Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, Jan 07, 2005 at 10:00:14AM +0100, Ingo Molnar wrote:
> > so my strong position is that even asking for any 'warning period' for
> > changes in VFS internals (including exports/unexports) would be
> > extremely rude.

No, I'd say that unexports are different.  They can clearly break existing
code and so should only be undertaken with caution, and with lengthy notice
if possible.

And it _is_ possible here, because there are no plans to change the
exported functions, and it's only two lines of code, dammit.

The cost to us of maintaining those two lines of code for a year is
basically zero.

The cost to others of us removing those two lines of code without warning
is appreciable.

Obvious solution: don't remove the two lines of code without warning.

The only reason I can see for peremptorily removing those two lines of code
is that there is some benefit to doing so which outweighs the downstream
cost of doing so.  Nobody has demonstrated such a benefit.

> <sarcasm>
> <osdl-salespitch>
> Unfortunately you don't have the financial and political powers IBM
> has, so your opinion doesn't matter as much.  Maybe you should become
> OSDL member to influence the direction of Linux development.
> </osdl-salespitch>
> </sarcasm>

Christoph, it would be better to constraint yourself to commenting on other
people's actions rather than entering into premature speculation regarding
their motivations, especially when that speculation involves accusations of
corruption.

I have outlined the reasons for delaying the removal of these exports.  If
you can demonstrate that those reasons are invalid, and that I had good
reason for also believing that those reasons are invalid then that would be
an appropriate stage at which to start to speculate about ulterior
motivations, thanks very much.