linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] add support for sysdev class attributes
Date: Fri, 7 Jan 2005 21:07:29 -0800	[thread overview]
Message-ID: <20050108050729.GA7587@kroah.com> (raw)
In-Reply-To: <1105136891.13391.20.camel@pants.austin.ibm.com>

On Fri, Jan 07, 2005 at 04:28:12PM -0600, Nathan Lynch wrote:
> @@ -88,6 +123,12 @@ int sysdev_class_register(struct sysdev_
>  	INIT_LIST_HEAD(&cls->drivers);
>  	cls->kset.subsys = &system_subsys;
>  	kset_set_kset_s(cls, system_subsys);
> +
> +	/* I'm not going to claim to understand this; see
> +	 * fs/sysfs/file::check_perm for how sysfs_ops are selected
> +	 */
> +	cls->kset.kobj.ktype = &sysdev_class_ktype;
> +

I think you need to understand this, and then submit a patch without
such a comment :)

And probably without such code, as I don't think you need to do that.

thanks,

greg k-h

  reply	other threads:[~2005-01-08  5:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-07 22:28 [RFC/PATCH] add support for sysdev class attributes Nathan Lynch
2005-01-08  5:07 ` Greg KH [this message]
2005-01-10 15:58   ` Nathan Lynch
2005-01-11 19:29     ` Greg KH
2005-01-18  4:02       ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050108050729.GA7587@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathanl@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).