* [-mm patch] always enable regparm on i386
@ 2005-01-08 20:50 Adrian Bunk
2005-01-08 23:52 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2005-01-08 20:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
The patch below always enables regparm on i386 (with gcc >= 3.0).
With this patch, it should get a better testing coverage in -mm.
If this doesn't cause any problems, I plan to send a patch to completely
remove the CONFIG_REGPARM option after 2.6.11 will be released.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-mm2-full/arch/i386/Kconfig.old 2005-01-08 17:41:49.000000000 +0100
+++ linux-2.6.10-mm2-full/arch/i386/Kconfig 2005-01-08 17:42:10.000000000 +0100
@@ -877,9 +877,8 @@
default y
config REGPARM
- bool "Use register arguments (EXPERIMENTAL)"
- depends on EXPERIMENTAL
- default n
+ bool
+ default y
help
Compile the kernel with -mregparm=3. This uses an different ABI
and passes the first three arguments of a function call in registers.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-mm patch] always enable regparm on i386
2005-01-08 20:50 [-mm patch] always enable regparm on i386 Adrian Bunk
@ 2005-01-08 23:52 ` Andrew Morton
2005-01-09 0:22 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2005-01-08 23:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> wrote:
>
> The patch below always enables regparm on i386 (with gcc >= 3.0).
>
> With this patch, it should get a better testing coverage in -mm.
>
> If this doesn't cause any problems, I plan to send a patch to completely
> remove the CONFIG_REGPARM option after 2.6.11 will be released.
-mregparm has revealed at least two kernel bugs thus far. The ability to
disable -mregparm is a useful diagnostic tool.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-mm patch] always enable regparm on i386
2005-01-08 23:52 ` Andrew Morton
@ 2005-01-09 0:22 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2005-01-09 0:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sat, Jan 08, 2005 at 03:52:48PM -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > The patch below always enables regparm on i386 (with gcc >= 3.0).
> >
> > With this patch, it should get a better testing coverage in -mm.
> >
> > If this doesn't cause any problems, I plan to send a patch to completely
> > remove the CONFIG_REGPARM option after 2.6.11 will be released.
>
> -mregparm has revealed at least two kernel bugs thus far. The ability to
> disable -mregparm is a useful diagnostic tool.
You are still able to disable it by editing the Kconfig file.
And even if the option will no longer be present at some time in the
future, it will be trivial to disable it in the Makefile.
But currently (an option depending on EXPERIMENTAL) the testing coverage
isn't that big, and with this -mm patch, most people using -mm [1] will
have it enabled and notice if other problems pop up.
cu
Adrian
[1] except for those with gcc < 3.0 or !i386
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
* [-mm patch] always enable regparm on i386
@ 2005-03-27 20:21 Adrian Bunk
2005-03-29 1:33 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2005-03-27 20:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
The patch below always enables regparm on i386 (with gcc >= 3.0).
With this patch, it should get a better testing coverage in -mm.
This patch should help to find bugs that show up with regparm enabled.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-mm2-full/arch/i386/Kconfig.old 2005-01-08 17:41:49.000000000 +0100
+++ linux-2.6.10-mm2-full/arch/i386/Kconfig 2005-01-08 17:42:10.000000000 +0100
@@ -877,9 +877,8 @@
default y
config REGPARM
- bool "Use register arguments (EXPERIMENTAL)"
- depends on EXPERIMENTAL
- default n
+ bool
+ default y
help
Compile the kernel with -mregparm=3. This uses an different ABI
and passes the first three arguments of a function call in registers.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-03-29 1:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-08 20:50 [-mm patch] always enable regparm on i386 Adrian Bunk
2005-01-08 23:52 ` Andrew Morton
2005-01-09 0:22 ` Adrian Bunk
2005-03-27 20:21 Adrian Bunk
2005-03-29 1:33 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).