linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@lst.de>
Cc: davej@redhat.com, hannal@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix pci_get_device conversion in intel-agp
Date: Sun, 9 Jan 2005 10:29:37 -0800	[thread overview]
Message-ID: <20050109182937.GA13531@kroah.com> (raw)
In-Reply-To: <20050108190815.GA7031@lst.de>

On Sat, Jan 08, 2005 at 08:08:15PM +0100, Christoph Hellwig wrote:
> +	if (intel_i810_private.i810_dev)
> +		pci_dev_put(intel_i810_private.i830_dev);
> +	if (intel_i810_private.i830_dev)
> +		pci_dev_put(intel_i830_private.i830_dev);

It's legal to call pci_dev_put() with a NULL pointer, so these checks
are not needed.

thanks,

greg k-h

      parent reply	other threads:[~2005-01-09 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-08 19:08 [PATCH] fix pci_get_device conversion in intel-agp Christoph Hellwig
2005-01-08 19:13 ` Roland Dreier
2005-01-08 19:14   ` Christoph Hellwig
2005-01-09 18:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050109182937.GA13531@kroah.com \
    --to=greg@kroah.com \
    --cc=davej@redhat.com \
    --cc=hannal@us.ibm.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).