From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: torvads@osdl.org, akpm@osdl.org, jlan@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: Move accounting function calls out of critical vm code paths
Date: Sun, 9 Jan 2005 18:43:20 -0800 [thread overview]
Message-ID: <20050110024320.GD2995@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0501051651140.10377@schroedinger.engr.sgi.com>
On Wed, Jan 05, 2005 at 04:55:14PM -0800, Christoph Lameter wrote:
> One disadvantage is that rss etc may now peak between stime
> increments without being noticed. But I think we are mostly
> interested in prolonged memory use rather than accurate data on the
> max rss ever reached.
This has the downside that applications may die well after the event
that caused the excess. Also, I can see situations in RT where strict
limits are put in place to ensure that particular apps are never
starved so strict accounting is occassionally desireable.
Perhaps we could do the accounting on the fly iff we have an rlimit in
the first place and we're already over half of it? Such strict
accounting could triggered by a process flag turned off and on inside
acct_update_integrals.
One also wonders if once per timer tick is more processing for compute
intensive workloads.
Finally, do { } while (0); is a bit of cargo cult. The compilers no
longer warn for empty statements so a null #define is fine.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2005-01-10 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 0:55 Move accounting function calls out of critical vm code paths Christoph Lameter
2005-01-10 2:43 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050110024320.GD2995@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvads@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).