linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /driver/net/wan/sbs520
Date: Mon, 10 Jan 2005 12:11:46 -0800	[thread overview]
Message-ID: <20050110121146.384e1ca3@dxpl.pdx.osdl.net> (raw)
In-Reply-To: 4F23E557A0317D45864097982DE907941A3383@pilotmail.sbscorp.sbs.com

Like most vendor drivers, this looks ugly full of obfuscating typedef's
and MixedCase. Please make it conform to linux style.

Also, all global's should be static where possible to avoid name space pollution.
Replace volatile with wmb() and rmb() which is probably what you need anyway.
Don't bury volatile inside typedef.s



  reply	other threads:[~2005-01-10 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-10 19:49 [PATCH] /driver/net/wan/sbs520 Adam Anthony
2005-01-10 20:11 ` Stephen Hemminger [this message]
2005-01-10 20:29 ` Francois Romieu
  -- strict thread matches above, loose matches on Subject: below --
2005-01-10 20:49 Adam Anthony
2005-01-10 17:47 Alexey Dobriyan
2005-01-10 17:26 ` Matthias-Christian Ott
2005-01-10 14:46 Adam Anthony
2005-01-10 18:00 ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050110121146.384e1ca3@dxpl.pdx.osdl.net \
    --to=shemminger@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).