From: Peter Martuccelli <peterm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: peterm@redhat.com, sgrubb@redhat.com, rl@hellgate.ch, akpm@osdl.com
Subject: [PATCH 2.6.10] audit return code and log format fix
Date: Mon, 10 Jan 2005 14:43:18 -0500 [thread overview]
Message-ID: <200501101943.j0AJhId3028056@redrum.boston.redhat.com> (raw)
Hello Andrew,
A couple of one liners to resolve two issues that have come up
regarding audit. Roger reported a problem with
audit.c:audit_receive_skb which improperly negates the errno
argument when netlink_ack is called. The second issue was reported
by Steve on the linux-audit list, auditsc.s:audit_log_exit using %u
instead of %d in the audit_log_format call.
Please incorporate the patch in the next version.
Please note, there is a mailing list available for audit discussion at
https://www.redhat.com/archives/linux-audit/
Signed-off-by: Peter Martuccelli <peterm@redhat.com>
Steve Grubb <sgrubb@redhat.com>
Roger Luethi <rl@hellgate.ch>
Regards,
Peter
diffstat:
audit.c | 2 +-
auditsc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp linux-2.6.10-pristine/kernel/audit.c linux-2.6.10/kernel/audit.c
--- linux-2.6.10-pristine/kernel/audit.c 2004-12-24 16:35:50.000000000 -0500
+++ linux-2.6.10/kernel/audit.c 2005-01-07 15:37:22.329915776 -0500
@@ -419,7 +419,7 @@ static int audit_receive_skb(struct sk_b
if (rlen > skb->len)
rlen = skb->len;
if ((err = audit_receive_msg(skb, nlh))) {
- netlink_ack(skb, nlh, -err);
+ netlink_ack(skb, nlh, err);
} else if (nlh->nlmsg_flags & NLM_F_ACK)
netlink_ack(skb, nlh, 0);
skb_pull(skb, rlen);
diff -Naurp linux-2.6.10-pristine/kernel/auditsc.c linux-2.6.10/kernel/auditsc.c
--- linux-2.6.10-pristine/kernel/auditsc.c 2004-12-24 16:35:24.000000000 -0500
+++ linux-2.6.10/kernel/auditsc.c 2005-01-07 15:37:17.675623336 -0500
@@ -591,7 +591,7 @@ static void audit_log_exit(struct audit_
if (context->personality != PER_LINUX)
audit_log_format(ab, " per=%lx", context->personality);
if (context->return_valid)
- audit_log_format(ab, " exit=%u", context->return_code);
+ audit_log_format(ab, " exit=%d", context->return_code);
audit_log_format(ab,
" a0=%lx a1=%lx a2=%lx a3=%lx items=%d"
" pid=%d loginuid=%d uid=%d gid=%d"
reply other threads:[~2005-01-10 19:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501101943.j0AJhId3028056@redrum.boston.redhat.com \
--to=peterm@redhat.com \
--cc=akpm@osdl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rl@hellgate.ch \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).