linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andries Brouwer <aebr@win.tue.nl>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Do PS/2 ESDI users exist?
Date: Tue, 11 Jan 2005 05:32:20 +0100	[thread overview]
Message-ID: <20050111043220.GB2760@pclin040.win.tue.nl> (raw)
In-Reply-To: <20050108234337.GE6052@pclin040.win.tue.nl>

Yesterday I mentioned that patch 2.3.13 killed the setup,
so that tp720_setup and ed_setup would not be called anymore.
Hand-specifying the geometry failed from then on.

Since nobody noticed, maybe nobody with compiled-in ps2esdi
needed to specify the geometry.

In 2.1.128 (Nov 1998) the driver was modularised, but that patch
contained a few typos so that the driver would not build as a module.
Several people - all without ps2 hardware - submitted a patch,
and the correction finally went into patch-2.6.0-test6 (Sep 2003).

All that time, no actual (potential) users complained.
So, maybe nobody tried to use it as a module.

Google shows that lots of people have CONFIG_BLK_DEV_PS2=m.
Why didn't they notice? Because that setting results (e.g. under 2.4) in
#undef  CONFIG_BLK_DEV_PS2
#define CONFIG_BLK_DEV_PS2_MODULE 1
in <linux/autoconf.h>, and ps2esdi.c is inside #ifdef CONFIG_BLK_DEV_PS2.

Have there ever existed ESDI users? Yes, using out-of-tree patches before
2.1.15, and in the 2.1 - 2.2 time frame. I seem to be unable to find traces
of later users - just a few people who try and fail.

I wonder whether ps2esdi should be removed.
Does the present driver work for someone?
Have there been users in this millennium? With 2.3 or later?

Andries

  reply	other threads:[~2005-01-11  4:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-08 21:40 [2.6 patch] drivers/block/ps2esdi.c: remove two unused functions (fwd) Adrian Bunk
2005-01-08 23:43 ` Andries Brouwer
2005-01-11  4:32   ` Andries Brouwer [this message]
2005-01-11  4:49     ` Do PS/2 ESDI users exist? Andrew Morton
2005-01-15 19:01       ` Andries Brouwer
2005-01-11 10:37     ` Erik Mouw
2005-01-11 16:10     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050111043220.GB2760@pclin040.win.tue.nl \
    --to=aebr@win.tue.nl \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).