From: Greg KH <greg@kroah.com>
To: Paul Mundt <paul.mundt@nokia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SuperHyway bus support
Date: Wed, 12 Jan 2005 00:17:22 -0800 [thread overview]
Message-ID: <20050112081722.GA2745@kroah.com> (raw)
In-Reply-To: <20050107162945.GA19043@pointless.research.nokia.com>
On Fri, Jan 07, 2005 at 06:29:45PM +0200, Paul Mundt wrote:
> On Fri, Jan 07, 2005 at 11:41:04AM +0200, Paul Mundt wrote:
> > > Also, why have a local list of devices and not just use the list the
> > > driver core provides for you?
> > >
> > Probably because I wasn't aware that the driver core provided one. Now that I
> > see the bus_for_each_xxx() stuff I'll drop the list and use that instead.
> >
> I dropped this entirely as the release() stuff did what I was looking for..
>
> > Thanks for looking at this, I'll post a cleaned up version shortly.
>
> Here it is against current BK.. let me know if you have any other issues.
>
> Signed-off-by: Paul Mundt <paul.mundt@nokia.com>
>
> drivers/Makefile | 1
> drivers/sh/Makefile | 6
> drivers/sh/superhyway/Makefile | 7 +
> drivers/sh/superhyway/superhyway-sysfs.c | 47 +++++++
> drivers/sh/superhyway/superhyway.c | 205 +++++++++++++++++++++++++++++++
No Kconfig file to enable this option?
> +static struct device superhyway_bus_device = {
> + .bus_id = "superhyway",
> +};
This device doesn't have a release function, as it's tied to the module.
Are you sure it's race free? :)
> +static int __init superhyway_init(void)
> +{
> + extern int superhyway_scan_bus(void);
This should go in a .h file somewhere.
> +EXPORT_SYMBOL(superhyway_bus_type);
> +EXPORT_SYMBOL(superhyway_add_device);
> +EXPORT_SYMBOL(superhyway_register_driver);
> +EXPORT_SYMBOL(superhyway_unregister_driver);
Did you forget a .h file with these function prototypes?
Other than that, looks a whole lot better, nice job.
greg k-h
next prev parent reply other threads:[~2005-01-12 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-27 7:52 [PATCH] SuperHyway bus support Paul Mundt
2005-01-07 7:22 ` Greg KH
2005-01-07 9:41 ` Paul Mundt
2005-01-07 16:29 ` Paul Mundt
2005-01-12 8:17 ` Greg KH [this message]
2005-01-12 12:48 ` Paul Mundt
2005-01-25 14:08 ` Paul Mundt
2005-01-25 20:30 ` Greg KH
2005-02-01 22:05 ` Greg KH
2005-02-01 22:23 ` Sam Ravnborg
2005-02-01 22:30 ` Greg KH
2005-02-02 7:04 ` Paul Mundt
2005-02-02 7:10 ` Paul Mundt
2005-02-02 22:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112081722.GA2745@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.mundt@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).