From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261474AbVALVhw (ORCPT ); Wed, 12 Jan 2005 16:37:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261329AbVALVg5 (ORCPT ); Wed, 12 Jan 2005 16:36:57 -0500 Received: from mail.kroah.org ([69.55.234.183]:62152 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261460AbVALVaM (ORCPT ); Wed, 12 Jan 2005 16:30:12 -0500 Date: Wed, 12 Jan 2005 13:29:54 -0800 From: Greg KH To: "Michael S. Tsirkin" Cc: Andrew Morton , Takashi Iwai , ak@suse.de, mingo@elte.hu, rlrevell@joe-job.com, linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org, gordon.jin@intel.com, alsa-devel@lists.sourceforge.net, VANDROVE@vc.cvut.cz Subject: Re: [PATCH] fix: macros to detect existance of unlocked_ioctl and compat_ioctl Message-ID: <20050112212954.GA13558@kroah.com> References: <20041215065650.GM27225@wotan.suse.de> <20041217014345.GA11926@mellanox.co.il> <20050103011113.6f6c8f44.akpm@osdl.org> <20050105144043.GB19434@mellanox.co.il> <20050105133448.59345b04.akpm@osdl.org> <20050106140636.GE25629@mellanox.co.il> <20050112203606.GA23307@mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050112203606.GA23307@mellanox.co.il> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 12, 2005 at 10:36:06PM +0200, Michael S. Tsirkin wrote: > To make life bearable for out-of kernel modules, the following patch > adds 2 macros so that existance of unlocked_ioctl and compat_ioctl > can be easily detected. > > Signed-off-by: Michael S. Tsirkin > > diff -puN include/linux/fs.h~ioctl-rework include/linux/fs.h > --- 25/include/linux/fs.h~ioctl-rework Thu Dec 16 15:48:31 2004 > +++ 25-akpm/include/linux/fs.h Thu Dec 16 15:48:31 2004 > @@ -907,6 +907,12 @@ typedef struct { > > typedef int (*read_actor_t)(read_descriptor_t *, struct page *, unsigned long, unsigned long); > > +/* These macros are for out of kernel modules to test that > + * the kernel supports the unlocked_ioctl and compat_ioctl > + * fields in struct file_operations. */ > +#define HAVE_COMPAT_IOCTL 1 > +#define HAVE_UNLOCKED_IOCTL 1 No, we do not do that in the kernel today, and I'm pretty sure we don't want to start doing it (it would get _huge_ very quickly...) Please don't apply this. Remember, out-of-the-tree modules are on their own. thanks, greg k-h