From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261765AbVAMXnE (ORCPT ); Thu, 13 Jan 2005 18:43:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261808AbVAMXkl (ORCPT ); Thu, 13 Jan 2005 18:40:41 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:36045 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S261820AbVAMXbW (ORCPT ); Thu, 13 Jan 2005 18:31:22 -0500 Date: Thu, 13 Jan 2005 15:29:04 -0800 From: Greg KH To: Jonas Munsin , Jean Delvare , pioppo@ferrara.linux.it, sensors@Stimpy.netroedge.com, djg@pdp8.net, LKML Subject: Re: 2.6.10-mm2: it87 sensor driver stops CPU fan Message-ID: <20050113232904.GC2458@kroah.com> References: <200501102341.44949.pioppo@ferrara.linux.it> <20050112222735.GA13572@nemo.sby.abo.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050112222735.GA13572@nemo.sby.abo.fi> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 13, 2005 at 12:27:35AM +0200, Jonas Munsin wrote: > > 2* I would then add a check to the it87 driver, which completely disables > > the fan speed control interface if the initial configuration looks weird > > (all fans supposedly stopped and polarity set to "active low"). This > > should protect users of the driver who have a faulty BIOS. > > > > When a bogus configuration is detected, we would of course complain in > > the logs and invite the user to complain to his/her motherboard maker > > too. > > Here is it87.c_2.6.10-jm4-detect_broken_bios_20050112.diff implementing > this. It goes on top of the previous patch. > > - detects broken bioses, disables the pwm for them and prints a message > - fixes an unrelated minor bug in set_fan_div() > > Signed-off-by: Jean Delvare > Signed-off-by: Jonas Munsin Applied, thanks. greg k-h