From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261489AbVAUAJa (ORCPT ); Thu, 20 Jan 2005 19:09:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261500AbVAUAJa (ORCPT ); Thu, 20 Jan 2005 19:09:30 -0500 Received: from mail.mellanox.co.il ([194.90.237.34]:61298 "EHLO mtlex01.yok.mtl.com") by vger.kernel.org with ESMTP id S261489AbVAUAJH (ORCPT ); Thu, 20 Jan 2005 19:09:07 -0500 Date: Fri, 21 Jan 2005 02:09:35 +0200 From: "Michael S. Tsirkin" To: Andrew Morton , Chris Wright , ak@suse.de Cc: Greg KH , tiwai@suse.de, mingo@elte.hu, rlrevell@joe-job.com, linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org, gordon.jin@intel.com, alsa-devel@lists.sourceforge.net, VANDROVE@vc.cvut.cz Subject: security hook missing in compat ioctl in 2.6.11-rc1-mm2 Message-ID: <20050121000935.GA341@mellanox.co.il> Reply-To: "Michael S. Tsirkin" References: <20050103011113.6f6c8f44.akpm@osdl.org> <20050105144043.GB19434@mellanox.co.il> <20050105133448.59345b04.akpm@osdl.org> <20050106140636.GE25629@mellanox.co.il> <20050112203606.GA23307@mellanox.co.il> <20050112212954.GA13558@kroah.com> <20050112214326.GB14703@wotan.suse.de> <20050112225230.GA14590@kroah.com> <20050112151049.7473db7d.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050119213818.55b14bb0.akpm@osdl.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! Security hook seems to be missing before compat_ioctl in mm2. And, it would be nice to avoid calling it twice on some paths. Chris Wright's patch addressed this in the most elegant way I think, by adding vfs_ioctl. Accordingly, this change: @@ -468,6 +496,11 @@ asmlinkage long compat_sys_ioctl(unsigne found_handler: if (t->handler) { + /* RED-PEN how should LSM module know it's handling 32bit? */ + error = security_file_ioctl(filp, cmd, arg); + if (error) + goto out_fput; + lock_kernel(); error = t->handler(fd, cmd, arg, filp); unlock_kernel(); from Andy's "some fixes" patch wont be needed. Chris - are you planning to update your patch to -rc1-mm2? I'd like to see this addressed, after this I believe logically we'll get everything right, then I have a couple of small cosmetic patches, and I believe we'll be set. -- I dont speak for Mellanox.