From: Christopher Li <chrisl@vmware.com>
To: Andi Kleen <ak@muc.de>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: compat ioctl for submiting URB
Date: Fri, 28 Jan 2005 23:55:09 -0500 [thread overview]
Message-ID: <20050129045509.GC12806@64m.dyndns.org> (raw)
In-Reply-To: <m1llaclp6s.fsf@muc.de>
On Sat, Jan 29, 2005 at 07:33:31AM +0100, Andi Kleen wrote:
>
> Looks reasonable from a first look.
>
> Issues:
> - Should use CONFIG_COMPAT, not x86-64 specific symbols
Agree.
> - Why can't you set URB_COMPAT transparently in the emulation
> layer? Then existing applications would hopefully work without
> changes, right?
The existing application is don't need to set the USB_COMPAT flag.
It is use internally to track the URB is submit from 32 bit user
space. I guess I don't have to use that flag.
>
> You may also want to preserve the __user casts, otherwise
> Al Viro and other sparse users will be unhappy.
I did try. Which place are you referring to? I guess miss some of
it.
Chris
>
> Thanks for attacking this long standing problem.
>
> -Andi
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2005-01-29 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 21:23 compat ioctl for submiting URB Christopher Li
2005-01-29 4:29 ` Gianni Tedesco
2005-01-29 1:33 ` Christopher Li
2005-01-29 5:45 ` Roland Dreier
2005-01-29 4:30 ` Christopher Li
2005-01-29 5:47 ` Al Viro
2005-01-29 6:28 ` Andi Kleen
2005-01-29 6:33 ` Andi Kleen
2005-01-29 4:55 ` Christopher Li [this message]
2005-01-29 5:58 ` [PATCH] compat USB ioctl take II was " Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129045509.GC12806@64m.dyndns.org \
--to=chrisl@vmware.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).