From: Jean Delvare <khali@linux-fr.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Ian Campbell <icampbell@arcom.com>
Subject: [PATCH 2.4] I2C updates for 2.4.29 (1/3)
Date: Sat, 29 Jan 2005 12:14:55 +0100 [thread overview]
Message-ID: <20050129121455.1ee24c88.khali@linux-fr.org> (raw)
In-Reply-To: <20050129120235.5c7160e6.khali@linux-fr.org>
Original reports and discussion:
http://archives.andrew.net.au/lm-sensors/msg28512.html
http://archives.andrew.net.au/lm-sensors/msg28581.html
Bottom line:
The "bit" and "pcf" i2c algorithms should declare themselves fully I2C
capable, but do not.
Credits go to Ian Campbell for noticing and proposing patches.
This is a backport from Linux 2.6.11-rc1.
--- linux-2.4.29/drivers/i2c/i2c-algo-bit.c.orig 2004-02-18 14:36:31.000000000 +0100
+++ linux-2.4.29/drivers/i2c/i2c-algo-bit.c 2005-01-29 11:33:33.000000000 +0100
@@ -522,8 +522,8 @@
static u32 bit_func(struct i2c_adapter *adap)
{
- return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_10BIT_ADDR |
- I2C_FUNC_PROTOCOL_MANGLING;
+ return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL |
+ I2C_FUNC_10BIT_ADDR | I2C_FUNC_PROTOCOL_MANGLING;
}
--- linux-2.4.29/drivers/i2c/i2c-algo-pcf.c.orig 2005-01-29 11:40:01.000000000 +0100
+++ linux-2.4.29/drivers/i2c/i2c-algo-pcf.c 2005-01-29 11:33:40.000000000 +0100
@@ -435,8 +435,8 @@
static u32 pcf_func(struct i2c_adapter *adap)
{
- return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_10BIT_ADDR |
- I2C_FUNC_PROTOCOL_MANGLING;
+ return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL |
+ I2C_FUNC_10BIT_ADDR | I2C_FUNC_PROTOCOL_MANGLING;
}
/* -----exported algorithm data: ------------------------------------- */
--
Jean Delvare
http://khali.linux-fr.org/
next prev parent reply other threads:[~2005-01-29 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 11:02 I2C updates for 2.4.29 Jean Delvare
2005-01-29 11:14 ` Jean Delvare [this message]
2005-01-29 11:28 ` [PATCH 2.4] I2C updates for 2.4.29 (2/3) Jean Delvare
2005-01-29 11:37 ` [PATCH 2.4] I2C updates for 2.4.29 (3/3) Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129121455.1ee24c88.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).