From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261353AbVAaUMk (ORCPT ); Mon, 31 Jan 2005 15:12:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261347AbVAaUMk (ORCPT ); Mon, 31 Jan 2005 15:12:40 -0500 Received: from mx1.elte.hu ([157.181.1.137]:40581 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S261338AbVAaUMg (ORCPT ); Mon, 31 Jan 2005 15:12:36 -0500 Date: Mon, 31 Jan 2005 21:11:41 +0100 From: Ingo Molnar To: Lorenzo =?iso-8859-1?Q?Hern=E1ndez_Garc=EDa-Hierro?= Cc: Adrian Bunk , Valdis.Kletnieks@vt.edu, Arjan van de Ven , Stephen Hemminger , "linux-kernel@vger.kernel.org" , Chris Wright , netdev@oss.sgi.com, Hank Leininger , "David S. Miller" , linux@horizon.com Subject: Re: [PATCH] OpenBSD Networking-related randomization port Message-ID: <20050131201141.GA4879@elte.hu> References: <1106932637.3778.92.camel@localhost.localdomain> <20050128100229.5c0e4ea1@dxpl.pdx.osdl.net> <1106937110.3864.5.camel@localhost.localdomain> <20050128105217.1dc5ef42@dxpl.pdx.osdl.net> <1106944492.3864.30.camel@localhost.localdomain> <1106945266.7776.41.camel@laptopd505.fenrus.org> <200501290915.j0T9FkVY012948@turing-police.cc.vt.edu> <20050131165025.GN18316@stusta.de> <1107192218.3754.86.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1107192218.3754.86.camel@localhost.localdomain> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Lorenzo Hernández García-Hierro wrote: > > At least the three clause BSD license is GPL compatible. > > Yes, AFAIK :) > > I will try to follow Arjan's recommendations on using his functions > instead of obsd ones, even if I think it should be alone in the > current file. Also I will split up the patch. could you please also react to this feedback: http://marc.theaimsgroup.com/?l=linux-kernel&m=110698371131630&w=2 to quote a couple of key points from that very detailed security analysis: " I'm not sure how the OpenBSD code is better in any way. (Notice that it uses the same "half_md4_transform" as Linux; you just added another copy.) Is there a design note on how the design was chosen? " that mail also includes a much smaller patch to random.c. ( Obviously the more fundamental questions have to be solved prior solving code-level problems, patch splitup and patch ordering - often one ends up having a much smaller patch to work with, by thinking more about the fundamentals. ) Ingo