From: Jesse Barnes <jbarnes@sgi.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jon Smirl <jonsmirl@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] quiet non-x86 option ROM warnings
Date: Wed, 16 Feb 2005 15:54:00 -0800 [thread overview]
Message-ID: <200502161554.02110.jbarnes@sgi.com> (raw)
In-Reply-To: <1108515817.13375.63.camel@gaston>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Tuesday, February 15, 2005 5:03 pm, Benjamin Herrenschmidt wrote:
> What about printing "No PCI ROM detected" ? I like having that info when
> getting user reports, but I agree that a less worrying message would
> be good.
Ok, how about this then? It changes the printks in both drivers to KERN_INFO
and describes the situation a bit more accurately.
Signed-off-by: Jesse Barnes <jbarnes@sgi.com>
Thanks,
Jesse
P.S. Jon, I think the pci_map_rom code is buggy--if the option ROM signature
is missing or indicates that there's no ROM, the routine still returns a
valid pointer making the caller thing it succeeded. If we fix that up we can
fix up the callers.
[-- Attachment #2: aty-no-rom-present-cleanup.patch --]
[-- Type: text/x-diff, Size: 1089 bytes --]
===== drivers/video/aty/radeon_base.c 1.39 vs edited =====
--- 1.39/drivers/video/aty/radeon_base.c 2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/radeon_base.c 2005-02-16 15:48:48 -08:00
@@ -330,8 +330,8 @@
/* Very simple test to make sure it appeared */
if (BIOS_IN16(0) != 0xaa55) {
- printk(KERN_ERR "radeonfb (%s): Invalid ROM signature %x should be"
- "0xaa55\n", pci_name(rinfo->pdev), BIOS_IN16(0));
+ printk(KERN_INFO "radeonfb (%s): no ROM present\n",
+ pci_name(rinfo->pdev));
goto failed;
}
/* Look for the PCI data to check the ROM type */
===== drivers/video/aty/aty128fb.c 1.56 vs edited =====
--- 1.56/drivers/video/aty/aty128fb.c 2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/aty128fb.c 2005-02-16 15:50:12 -08:00
@@ -813,8 +813,8 @@
/* Very simple test to make sure it appeared */
if (BIOS_IN16(0) != 0xaa55) {
- printk(KERN_ERR "aty128fb: Invalid ROM signature %x should be 0xaa55\n",
- BIOS_IN16(0));
+ printk(KERN_INFO "aty128fb (%s): no ROM present\n",
+ pci_name(dev));
goto failed;
}
next prev parent reply other threads:[~2005-02-16 23:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 23:57 [PATCH] quiet non-x86 option ROM warnings Jesse Barnes
2005-02-16 0:36 ` Jon Smirl
2005-02-16 0:45 ` Jesse Barnes
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:08 ` Jon Smirl
2005-02-16 1:57 ` Jesse Barnes
2005-02-16 4:00 ` Benjamin Herrenschmidt
2005-02-16 1:03 ` Benjamin Herrenschmidt
2005-02-16 23:54 ` Jesse Barnes [this message]
2005-02-17 0:48 ` Benjamin Herrenschmidt
2005-02-17 16:33 ` Jon Smirl
2005-02-17 17:29 ` Jesse Barnes
2005-02-17 17:32 ` Jon Smirl
2005-02-17 17:41 ` Jesse Barnes
2005-02-17 17:45 ` Jesse Barnes
2005-02-17 17:56 ` Jon Smirl
2005-02-17 22:48 ` Benjamin Herrenschmidt
2005-02-17 22:47 ` Benjamin Herrenschmidt
2005-02-17 22:59 ` Jon Smirl
2005-02-17 23:00 ` Jesse Barnes
2005-02-17 23:04 ` Benjamin Herrenschmidt
2005-02-17 23:20 ` Andrew Vasquez
2005-02-17 22:45 ` Benjamin Herrenschmidt
2005-02-17 22:56 ` Jon Smirl
2005-02-18 12:09 ` Gabriel Paubert
2005-02-18 16:50 ` Jon Smirl
2005-09-04 13:27 ` Olaf Hering
2005-09-04 14:20 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502161554.02110.jbarnes@sgi.com \
--to=jbarnes@sgi.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).