* [2.6 patch] drivers/net/sb1000.c: make some variables static
@ 2005-02-19 0:03 Adrian Bunk
2005-02-21 1:37 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-02-19 0:03 UTC (permalink / raw)
To: jgarzik; +Cc: linux-net, linux-kernel
This patch makes some needlessly global variables static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/sb1000.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/sb1000.c.old 2005-02-16 18:17:09.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/sb1000.c 2005-02-16 18:18:02.000000000 +0100
@@ -57,9 +57,9 @@
#include <asm/uaccess.h>
#ifdef SB1000_DEBUG
-int sb1000_debug = SB1000_DEBUG;
+static int sb1000_debug = SB1000_DEBUG;
#else
-int sb1000_debug = 1;
+static int sb1000_debug = 1;
#endif
static const int SB1000_IO_EXTENT = 8;
@@ -247,12 +247,12 @@
.remove = sb1000_remove_one,
};
-\f
+
/*
* SB1000 hardware routines to be used during open/configuration phases
*/
-const int TimeOutJiffies = (875 * HZ) / 100;
+static const int TimeOutJiffies = (875 * HZ) / 100;
static inline void nicedelay(unsigned long usecs)
{
@@ -359,11 +359,11 @@
return 0;
}
-\f
+
/*
* SB1000 hardware routines to be used during frame rx interrupt
*/
-const int Sb1000TimeOutJiffies = 7 * HZ;
+static const int Sb1000TimeOutJiffies = 7 * HZ;
/* Card Wait For Ready (to be used during frame rx) */
static inline int
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/net/sb1000.c: make some variables static
2005-02-19 0:03 [2.6 patch] drivers/net/sb1000.c: make some variables static Adrian Bunk
@ 2005-02-21 1:37 ` Jeff Garzik
2005-02-21 14:48 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2005-02-21 1:37 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-net, linux-kernel
this patch eats formfeeds
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/net/sb1000.c: make some variables static
2005-02-21 1:37 ` Jeff Garzik
@ 2005-02-21 14:48 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-02-21 14:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-net, linux-kernel
On Sun, Feb 20, 2005 at 08:37:08PM -0500, Jeff Garzik wrote:
> this patch eats formfeeds
Sorry, updated patch:
<-- snip -->
This patch makes some needlessly global variables static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/sb1000.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.11-rc3-mm2-full/drivers/net/sb1000.c.old 2005-02-16 18:17:09.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/sb1000.c 2005-02-21 15:16:35.000000000 +0100
@@ -57,9 +57,9 @@
#include <asm/uaccess.h>
#ifdef SB1000_DEBUG
-int sb1000_debug = SB1000_DEBUG;
+static int sb1000_debug = SB1000_DEBUG;
#else
-int sb1000_debug = 1;
+static int sb1000_debug = 1;
#endif
static const int SB1000_IO_EXTENT = 8;
@@ -252,7 +252,7 @@
* SB1000 hardware routines to be used during open/configuration phases
*/
-const int TimeOutJiffies = (875 * HZ) / 100;
+static const int TimeOutJiffies = (875 * HZ) / 100;
static inline void nicedelay(unsigned long usecs)
{
@@ -363,7 +363,7 @@
/*
* SB1000 hardware routines to be used during frame rx interrupt
*/
-const int Sb1000TimeOutJiffies = 7 * HZ;
+static const int Sb1000TimeOutJiffies = 7 * HZ;
/* Card Wait For Ready (to be used during frame rx) */
static inline int
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-21 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-19 0:03 [2.6 patch] drivers/net/sb1000.c: make some variables static Adrian Bunk
2005-02-21 1:37 ` Jeff Garzik
2005-02-21 14:48 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).