From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261644AbVDNXUg (ORCPT ); Thu, 14 Apr 2005 19:20:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261646AbVDNXUg (ORCPT ); Thu, 14 Apr 2005 19:20:36 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:9991 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261644AbVDNXUa (ORCPT ); Thu, 14 Apr 2005 19:20:30 -0400 Date: Fri, 15 Apr 2005 01:20:28 +0200 From: Adrian Bunk To: Alan Cox Cc: netdev@oss.sgi.com, Linux Kernel Mailing List Subject: Re: [2.6 patch] drivers/net/wan/: possible cleanups Message-ID: <20050414232028.GD20400@stusta.de> References: <20050327143418.GE4285@stusta.de> <1111941516.14877.325.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1111941516.14877.325.camel@localhost.localdomain> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote: > On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote: > > - syncppp.c: sppp_input > > - syncppp.c: sppp_change_mtu > > - z85230.c: z8530_dma_sync > > - z85230.c: z8530_txdma_sync > > Please leave the z85230 ones at least. They are an intentional part of > the external API for writing other 85230 card drivers. If they are part of an API, why aren't the prototypes for them in any header file? > Alan cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed