linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Benoit Boissinot <bboissin@gmail.com>
Cc: Matt Tolentino <metolent@snoqualmie.dp.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] minor syctl fix in vsyscall_init
Date: 22 Apr 2005 13:31:30 +0200
Date: Fri, 22 Apr 2005 13:31:30 +0200	[thread overview]
Message-ID: <20050422113130.GA19292@muc.de> (raw)
In-Reply-To: <40f323d0050421091625659f16@mail.gmail.com>

On Thu, Apr 21, 2005 at 06:16:48PM +0200, Benoit Boissinot wrote:
> On 13 Apr 2005 20:29:13 +0200, Andi Kleen <ak@muc.de> wrote:
> > On Wed, Apr 13, 2005 at 10:45:18AM -0700, Matt Tolentino wrote:
> > >
> > > Andi,
> > >
> > > If CONFIG_SYCTL is not enabled then the x86-64 tree
> > > fails to build due to use of a symbol that is not
> > > compiled in.  Don't bother compiling in the sysctl
> > > register call if not building with sysctl.
> > 
> > Thanks. Actually it would be better to fix up sysctl.h
> > to define dummy functions in this case. I thought it did
> > that already in fact....
> > 
> 
> Yes it already does that, but kernel_root_table2 is not defined when
> CONFIG_SYSCTL is not set (the problem isn't with
> register_sysctl_table).
> 
> With 2.6.12-rc3:
> arch/x86_64/kernel/vsyscall.c: In function `vsyscall_init':
> arch/x86_64/kernel/vsyscall.c:221: error: `kernel_root_table2'
> undeclared (first use in this function)
> 
> If you prefer, i can send a patch which sets kernel_table_root2 to
> NULL when CONFIG_SYSCTL is not set. Or maybe there a better fix (btw
> is sysctl_vsyscall needed when !CONFIG_SYSCTL ?).

Hmpf ok. I assumed they were macros who ignore their arguments.
The original patch was fine, thanks.

-Andi

      reply	other threads:[~2005-04-22 11:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-13 17:45 [patch] minor syctl fix in vsyscall_init Matt Tolentino
2005-04-13 18:29 ` Andi Kleen
2005-04-21 16:16   ` Benoit Boissinot
2005-04-22 11:31     ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050422113130.GA19292@muc.de \
    --to=ak@muc.de \
    --cc=bboissin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metolent@snoqualmie.dp.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).