From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261772AbVEJULu (ORCPT ); Tue, 10 May 2005 16:11:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261773AbVEJULu (ORCPT ); Tue, 10 May 2005 16:11:50 -0400 Received: from lyle.provo.novell.com ([137.65.81.174]:38053 "EHLO lyle.provo.novell.com") by vger.kernel.org with ESMTP id S261772AbVEJULp (ORCPT ); Tue, 10 May 2005 16:11:45 -0400 Date: Tue, 10 May 2005 13:11:44 -0700 From: Greg KH To: Matthew Dobson Cc: Keiichiro Tokunaga , linux-kernel@vger.kernel.org, akpm@osdl.org Subject: Re: [RFC/PATCH] unregister_node() for hotplug use Message-ID: <20050510201144.GA3226@suse.de> References: <20050422003920.GD6829@kroah.com> <20050422113211.509005f1.tokunaga.keiich@jp.fujitsu.com> <20050425230333.6b8dfb33.tokunaga.keiich@jp.fujitsu.com> <20050426065431.GB5889@suse.de> <20050507211141.4829d4c0.tokunaga.keiich@jp.fujitsu.com> <427FE7B3.8080200@us.ibm.com> <20050510202053.3ddd9e7b.tokunaga.keiich@jp.fujitsu.com> <4280FA41.3050403@us.ibm.com> <20050510184508.GA2463@suse.de> <4281045C.4020205@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4281045C.4020205@us.ibm.com> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2005 at 11:58:36AM -0700, Matthew Dobson wrote: > Greg KH wrote: > > On Tue, May 10, 2005 at 11:15:29AM -0700, Matthew Dobson wrote: > > > >>So I think it's probably a good idea to stick the __devinit on > >>register_node() and unregister_node(), otherwise we have no marker to know > >>which functions to remove for CONFIG_TINY. Greg? > > > > > > Like _anyone_ would have CONFIG_NUMA and CONFIG_TINY enabled at the same > > time? I don't think so... > > > > I'll leave it as is for now. > > No, it seems unlikely that anyone would build with CONFIG_NUMA and > CONFIG_TINY both enabled. But it is possible and reasonable to build with > CONFIG_NUMA=y and CONFIG_HOTPLUG=n, which is the case I was trying to speak > to. If NUMA is on and HOTPLUG is off, then we're wasting kernel text > (granted, it's a very small amount of space) for the register_node() & > unregister_node() functions that we *know* will never be called after > initial bootup. That's why I suggested marking both of those functions as > __devinit. But it doesn't make a huge difference either way. I do not think this is an issue, and I want to move CONFIG_HOTPLUG to be under CONFIG_TINY anyway, so you could only disable it if TINY is enabled. But that's a different email thread... thanks, greg k-h