linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Pavel Machek <pavel@suse.cz>
Cc: Andi Kleen <ak@suse.de>, Alexander Nyberg <alexn@telia.com>,
	Jan Beulich <JBeulich@novell.com>,
	discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [discuss] Re: [PATCH] adjust x86-64 watchdog tick calculation
Date: Sun, 15 May 2005 12:36:46 +0200	[thread overview]
Message-ID: <20050515103646.GF26242@wotan.suse.de> (raw)
In-Reply-To: <20050513195215.GC3135@elf.ucw.cz>

On Fri, May 13, 2005 at 09:52:15PM +0200, Pavel Machek wrote:
> On P? 13-05-05 13:30:23, Andi Kleen wrote:
> > > Because it kills machine when interrupt latency gets too high?
> > > Like reading battery status using i2c...
> > 
> > That's a bug in the I2C reader then. Don't shot the messenger for bad news.
> 
> Disagreed.
> 
> Linux is not real time OS. Perhaps some real-time constraints "may not
> spend > 100msec with interrupts disabled" would be healthy, but it
> certainly needs more discussion than "lets enable NMI
> watchdog.". It needs to be written somewhere in big bold letters, too.

While linux is not a real time OS it has been always known that
turning off interrupts for a long time is extremly rude.

If you really want you can use touch_nmi_watchdog in the delay
loop then.  But note you have to compile it in, because touch_nmi_watchdog
is not exported (Linus vetoed that for good reasons).

But again do you really need to disable interrupts during this
i2c access? Can't you just use a schedule_timeout() and a semaphore?
Why would other interrupts cause a problem during such a long delay?

-Andi

  parent reply	other threads:[~2005-05-15 10:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-12  8:27 [PATCH] adjust x86-64 watchdog tick calculation Jan Beulich
2005-05-12 10:00 ` Alexander Nyberg
2005-05-12 11:46   ` [discuss] " Andi Kleen
2005-05-12 14:29   ` Pavel Machek
2005-05-13 11:30     ` Andi Kleen
2005-05-13 19:52       ` Pavel Machek
2005-05-13 21:27         ` Lee Revell
2005-05-13 22:51           ` Pavel Machek
2005-05-13 22:56             ` Lee Revell
2005-05-13 23:21               ` Pavel Machek
2005-05-13 23:29               ` Dave Jones
2005-05-15 10:52               ` Andi Kleen
2005-05-15 10:36         ` Andi Kleen [this message]
2005-05-15 10:51           ` Pavel Machek
2005-05-15 10:54             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050515103646.GF26242@wotan.suse.de \
    --to=ak@suse.de \
    --cc=JBeulich@novell.com \
    --cc=alexn@telia.com \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).