From: Ingo Molnar <mingo@elte.hu>
To: Kristian Benoit <kbenoit@opersys.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: network driver disabled interrupts in PREEMPT_RT
Date: Mon, 13 Jun 2005 20:56:42 +0200 [thread overview]
Message-ID: <20050613185642.GA12463@elte.hu> (raw)
In-Reply-To: <1118688347.5792.12.camel@localhost>
* Kristian Benoit <kbenoit@opersys.com> wrote:
> Hi,
> I got lots of these messages when accessing the net running
> 2.6.12-rc6-RT-V0.7.48-25 :
>
> "network driver disabled interrupts: tg3_start_xmit+0x0/0x629 [tg3]"
>
> it seem to come from net/sched/sch_generic.c.
does the patch below fix it?
Ingo
--- linux/drivers/net/tg3.c.orig
+++ linux/drivers/net/tg3.c
@@ -3242,9 +3242,9 @@ static int tg3_start_xmit(struct sk_buff
* So we really do need to disable interrupts when taking
* tx_lock here.
*/
- local_irq_save(flags);
+ local_irq_save_nort(flags);
if (!spin_trylock(&tp->tx_lock)) {
- local_irq_restore(flags);
+ local_irq_restore_nort(flags);
return NETDEV_TX_LOCKED;
}
next prev parent reply other threads:[~2005-06-13 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-13 18:45 network driver disabled interrupts in PREEMPT_RT Kristian Benoit
2005-06-13 18:56 ` Ingo Molnar [this message]
2005-06-13 19:03 ` Christoph Hellwig
2005-06-14 5:58 ` Ingo Molnar
2005-06-17 2:53 ` Herbert Xu
2005-06-13 19:56 ` Kristian Benoit
2005-06-15 12:36 ` Serge Noiraud
2005-06-15 13:05 ` Ingo Molnar
2005-06-15 13:08 ` Serge Noiraud
2005-06-21 13:18 ` Ingo Molnar
2005-07-05 12:17 ` Serge Noiraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613185642.GA12463@elte.hu \
--to=mingo@elte.hu \
--cc=kbenoit@opersys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).