From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-2.6.12-rc6-mm1] blk: cfq_find_next_crq fix
Date: Thu, 16 Jun 2005 08:58:41 +0200 [thread overview]
Message-ID: <20050616065840.GC1483@suse.de> (raw)
In-Reply-To: <20050616035622.GA29153@htj.dyndns.org>
On Thu, Jun 16 2005, Tejun Heo wrote:
> Hello, Jens.
> Hello, Andrew.
>
> In cfq_find_next_crq(), cfq tries to find the next request by
> choosing one of two requests before and after the current one.
> Currently, when choosing the next request, if there's no next request,
> the next candidate is NULL, resulting in selection of the previous
> request. This results in weird scheduling. Once we reach the end, we
> always seek backward.
>
> The correct behavior is using the first request as the next
> candidate. cfq_choose_req() already has logics for handling wrapped
> requests.
Good spotting, applied. I'll set up an iosched git tree as well, with a
cfq-ts branch.
--
Jens Axboe
prev parent reply other threads:[~2005-06-16 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-16 3:56 [PATCH linux-2.6.12-rc6-mm1] blk: cfq_find_next_crq fix Tejun Heo
2005-06-16 6:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050616065840.GC1483@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).