Re: [PATCH 0/5] SUBCPUSETS: a resource control functionality using CPUSETS

[KUROSAWA Takahiro <kurosawa@valinux.co.jp>]

On Thu, 8 Sep 2005 00:23:23 -0700
Paul Jackson <pj@sgi.com> wrote:

> I've just started reading this - it seems well presented and I think
> you have put much effort into it.  Thank-you for posting it.

Thank you for reading my patches!

> I have not yet taken the time to understand it properly, but a couple
> of questions come to mind offhand.  I hope these questions will not be
> too silly.
> 
>  1) What is the relation of this patch set to CKRM?

My patches consist of two parts, one for subcpuset framework
and another for the cpu resource controller.
Subcpuset framework code doesn't have the relation to CKRM.
CKRM could probably use the cpu resource controller code as 
a resource controller of it with some modification.

>  2) Would a structure similar to Dinakar's patches to connect
>     cpusets and dynamic sched domains (posted to linux-mm)
>     work here as well?

Yes, subcpusets could work with the dynamic sched domains.
The cpu resource controller divides cpu resources by scaling 
time_slice of the tasks, so multiple subcpusets can be created
under the cpuset that has one cpu only.  So, uniprocessor systems
also could get the benefit of subcpusets-patched cpusets.

> My initial understanding is that subcpusets provide a way to partial
> out the proportion of cpu and memory used by various tasks.  A leaf
> node cpuset can partition the tasks attached to it into subsets, called
> subcpusets, where each subcpuset gets a proportion of cpu and memory
> available to the original leaf node cpuset.

That's right.

> I'm guessing you do not want such cpusets (the parents of subcpusets)
> to overlap, because if they did, it would seem to confuse the meaning
> of getting a fixed proportion of available cpu and memory resources.  I
> was a little surprised not to see any additional checks that
> cpu_exclusive and mem_exclusive must be set true in these cpusets, to
> insure non- overlapping cpusets.

Right - I don't want the parents of the subcpusets to overlap and 
I should add such checks, but wanted to know first what people would
think of subcpusets.

Regards,

KUROSAWA, Takahiro