From: Ashok Raj <ashok.raj@intel.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, ak@muc.de, discuss@x86-64.org
Subject: Dont use shortcut when using send_IPI_all in flat mode
Date: Wed, 21 Sep 2005 13:52:16 -0700 [thread overview]
Message-ID: <20050921135215.A14439@unix-os.sc.intel.com> (raw)
Hi
This got missed during the previous update for not doing shortcut
since it introduces race in IPI, when using flat mode.
The earlier patches addressed send_IPI_allbutself, this one
take care of the sendall() case as well.
Andrew: Please consider for -mm
--
Cheers,
Ashok Raj
- Open Source Technology Center
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
--------------------------------------------------------
arch/x86_64/kernel/genapic_flat.c | 4 ++++
1 files changed, 4 insertions(+)
Index: linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c
===================================================================
--- linux-2.6.14-rc1-mm1.orig/arch/x86_64/kernel/genapic_flat.c
+++ linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c
@@ -94,7 +94,11 @@ static void flat_send_IPI_allbutself(int
static void flat_send_IPI_all(int vector)
{
+#ifndef CONFIG_HOTPLUG_CPU
__send_IPI_shortcut(APIC_DEST_ALLINC, vector, APIC_DEST_LOGICAL);
+#else
+ flat_send_IPI_mask(cpu_online_map, vector);
+#endif
}
static int flat_apic_id_registered(void)
next reply other threads:[~2005-09-21 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-21 20:52 Ashok Raj [this message]
2005-09-22 9:44 ` Dont use shortcut when using send_IPI_all in flat mode Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921135215.A14439@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).