From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [swsusp] Rework image freeing
Date: Wed, 21 Sep 2005 23:19:44 +0200 [thread overview]
Message-ID: <20050921211944.GB2071@elf.ucw.cz> (raw)
In-Reply-To: <20050921135834.4fd73447.akpm@osdl.org>
Hi!
> >
> > + for_each_zone(zone) {
> > + for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn) {
> > + struct page * page;
> > + page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
> > + if (PageNosave(page) && PageNosaveFree(page)) {
> > + ClearPageNosave(page);
> > + ClearPageNosaveFree(page);
> > + free_page((long) page_address(page));
> > + }
>
> There doesn't seem to be much point in converting the pageframe address to
> a virtual address, then back to a pageframe address. Why not just do
> put_page() here?
I do not know what put_page does, and free_page() has some friendly
BUG_ONs. But if I should just do put_page(page); instead of
free_page((long) page_address(page)), that is okay with me.
[Sound of harddrive seeking and CPU fan going up as test kernel
compiles].
Pavel
--
if you have sharp zaurus hardware you don't need... you know my address
next prev parent reply other threads:[~2005-09-21 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-21 20:51 [swsusp] Rework image freeing Pavel Machek
2005-09-21 20:58 ` Andrew Morton
2005-09-21 21:19 ` Pavel Machek [this message]
2005-09-21 21:31 ` Andrew Morton
2005-09-21 21:11 ` Dave Hansen
2005-09-21 21:18 ` Dave Hansen
2005-09-21 21:23 ` Pavel Machek
2005-09-21 22:53 ` Rafael J. Wysocki
2005-09-22 4:54 ` Rafael J. Wysocki
2005-09-22 9:46 ` Pavel Machek
2005-09-23 20:52 ` Rafael J. Wysocki
2005-09-23 21:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921211944.GB2071@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).