From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750736AbVI1TSy (ORCPT ); Wed, 28 Sep 2005 15:18:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750738AbVI1TSx (ORCPT ); Wed, 28 Sep 2005 15:18:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:54695 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750736AbVI1TSx (ORCPT ); Wed, 28 Sep 2005 15:18:53 -0400 From: Andi Kleen To: "Rafael J. Wysocki" Subject: Re: [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3) Date: Wed, 28 Sep 2005 21:18:54 +0200 User-Agent: KMail/1.8.2 Cc: Pavel Machek , Andrew Morton , LKML , discuss@x86-64.org References: <200509281624.29256.rjw@sisk.pl> In-Reply-To: <200509281624.29256.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200509282118.54670.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 28 September 2005 16:24, Rafael J. Wysocki wrote: > Hi, > > The following patch fixes Bug #4959.  For this purpose it creates temporary > page translation tables including the kernel mapping (reused) and the > direct mapping (created from scratch) and makes swsusp switch to these > tables right before the image is restored. > > The code that generates the direct mapping is based on the code in > arch/x86_64/mm/init.c. Looks much better than before, but is there any reason you cannot share the code with the mm/init.c code? Also Suresh S. has a patch out to turn the initial page tables into initdata. It'll probably conflict with that. Needs to be coordinated with him. -Andi