linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rogier Wolff <R.E.Wolff@BitWizard.nl>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
	bbpetkov@yahoo.de, linux-kernel@vger.kernel.org,
	R.E.Wolff@BitWizard.nl
Subject: Re: [PATCH] remove check_region in drivers-char-specialix.c
Date: Thu, 29 Sep 2005 08:43:28 +0200	[thread overview]
Message-ID: <20050929064328.GB25802@bitwizard.nl> (raw)
In-Reply-To: <20050929020510.GR7992@ftp.linux.org.uk>

On Thu, Sep 29, 2005 at 03:05:10AM +0100, Al Viro wrote:
> On Wed, Sep 28, 2005 at 06:41:06PM -0700, Andrew Morton wrote:
>  
> > http://www.spinics.net/lists/kernel/msg399680.html
> 
> Ewww...  A lot of chunks consisting only of whitespace removals - great
> way to make patch less readable...
> 
> And yes, that second call of sx_request_io_range() must die.  BTW,
> what's wrong with use of mdelay() instead of that sx_long_delay()
> junk?  Replacing both calls of sx_long_delay() with mdelay(50) would do it...

Trust me: mdelay didn't exist when I wrote that.

The code calls the private function that does what I think should've
been kernel infrastructure all along to make it easy to either: 
change the body of the function to call the new infrastructure, or 
replace the call of the private function with the call to the new
infrastructure. 

	Roger. 

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ

  reply	other threads:[~2005-09-29  6:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28  8:37 [PATCH] remove check_region in drivers-char-specialix.c Borislav Petkov
2005-09-28 17:52 ` Al Viro
2005-09-28 22:28   ` Borislav Petkov
2005-09-29  1:10     ` Al Viro
2005-09-29  1:41       ` Andrew Morton
2005-09-29  2:05         ` Al Viro
2005-09-29  6:43           ` Rogier Wolff [this message]
2005-09-29  7:38           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050929064328.GB25802@bitwizard.nl \
    --to=r.e.wolff@bitwizard.nl \
    --cc=akpm@osdl.org \
    --cc=bbpetkov@yahoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).