From: Jean Delvare <khali@linux-fr.org>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Request only really used I/O ports in w83627hf driver
Date: Fri, 30 Sep 2005 23:46:43 +0200 [thread overview]
Message-ID: <20050930234643.7a7b06ce.khali@linux-fr.org> (raw)
In-Reply-To: <20050928024956.GA24527@vana.vc.cvut.cz>
Hi Petr,
> This patch changes w83627hf and w83627ehf drivers to reserve only ports
> 0x295-0x296, instead of full 0x290-0x297 range. While some other sensors
> chips respond to all addresses in 0x290-0x297 range, Winbond chips respond
> to 0x295-0x296 only (this behavior is implied by documentation, and matches
> behavior observed on real systems). This is not problem alone, as no
> BIOS was found to put something at these unused addresses, and sensors
> chip itself provides nothing there as well.
>
> But in addition to only respond to these two addresses, also BIOS vendors
> report in their ACPI-PnP structures that there is some resource at I/O
> address 0x295 of length 2. And when later this hwmon driver attempts to
> request region with base 0x290/length 8, it fails as one request_region
> cannot span more than one device.
>
> Due to this we have to ask only for region this hardware really occupies,
> otherwise driver cannot be loaded on systems with ACPI-PnP enabled.
>
> Signed-off-by: Petr Vandrovec <vandrove@vc.cvut.cz>
OK, looks good, applied to my local tree. I'll push it to Greg KH in a
week or so. Thanks.
--
Jean Delvare
prev parent reply other threads:[~2005-09-30 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 18:14 [PATCH] Request only really used I/O ports in w83627hf driver Petr Vandrovec
2005-09-07 19:07 ` Jean Delvare
2005-09-07 19:31 ` Petr Vandrovec
2005-09-25 17:57 ` Jean Delvare
2005-09-25 22:07 ` Petr Vandrovec
2005-09-28 2:49 ` Petr Vandrovec
2005-09-28 4:21 ` Grant Coady
2005-09-30 21:46 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930234643.7a7b06ce.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).