From: Herbert Xu <herbert@gondor.apana.org.au>
To: Adrian Bunk <bunk@stusta.de>
Cc: James Morris <jmorris@redhat.com>, Kausty <kkumbhalkar@gmail.com>,
linux-kernel@vger.kernel.org, davem@davemloft.net,
linux-crypto@vger.kernel.org
Subject: Re: [2.6 patch] crypto/api.c: remove the second argument of crypto_alg_available()
Date: Mon, 31 Oct 2005 22:58:37 +1100 [thread overview]
Message-ID: <20051031115837.GA352@gondor.apana.org.au> (raw)
In-Reply-To: <20051031054642.GD8009@stusta.de>
On Mon, Oct 31, 2005 at 06:46:42AM +0100, Adrian Bunk wrote:
>
> > IIRC, this was to allow future code to specify preferences for the type of
> > algorithm driver (e.g. hardware), but has not been used. This is an
> > example of why it's a bad idea to add infrastructure which isn't being
> > used at the time.
>
> Since it's still unused, a patch to remove this second argument is
> below.
I'll be using this field very soon to indicate that the caller intends
to find synchronous algorithms only as opposed to either synchronous or
asynchronous. So I'd like to keep it for now.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2005-10-31 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 12:48 crypto/api.c: crypto_alg_available(): flags param not used Kausty
2005-01-20 14:54 ` James Morris
2005-10-31 5:46 ` [2.6 patch] crypto/api.c: remove the second argument of crypto_alg_available() Adrian Bunk
2005-10-31 11:58 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031115837.GA352@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=kkumbhalkar@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).