From: Ingo Oeser <netdev@axxeo.de>
To: Mitchell Blank Jr <mitch@sfgoth.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Sridhar Samudrala <sri@us.ibm.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism
Date: Wed, 14 Dec 2005 14:18:48 +0100 [thread overview]
Message-ID: <200512141418.48388.netdev@axxeo.de> (raw)
In-Reply-To: <20051214121253.GB23393@gaz.sfgoth.com>
Mitchell Blank Jr wrote:
> Alan Cox wrote:
> > > +#define SK_CRIT_ALLOC(sk, flags) ((sk->sk_allocation & __GFP_CRITICAL) | flags)
> >
> > Lots of hidden conditional logic on critical paths.
>
> How expensive is it compared to the allocation itself?
Cost is readability here. You should open code this additional OR
Regards
Ingo Oeser
next prev parent reply other threads:[~2005-12-14 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 9:12 [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism Sridhar Samudrala
2005-12-14 11:17 ` Alan Cox
2005-12-14 12:12 ` Mitchell Blank Jr
2005-12-14 13:18 ` Ingo Oeser [this message]
2005-12-14 18:29 ` Sridhar Samudrala
2005-12-14 18:11 ` Sridhar Samudrala
2005-12-14 18:33 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512141418.48388.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).