From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Anderson Briglia <briglia.anderson@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 2/5] [RFC] Add MMC password protection (lock/unlock) support
Date: Wed, 14 Dec 2005 14:28:04 +0000 [thread overview]
Message-ID: <20051214142804.GB7124@flint.arm.linux.org.uk> (raw)
In-Reply-To: <e55525570512140531k110169fal9b8b6423b022aafc@mail.gmail.com>
On Wed, Dec 14, 2005 at 09:31:33AM -0400, Anderson Briglia wrote:
> + data.blksz_bits = blksz_bits(data_size);
> + data.blocks = 1;
See my comments in your first mail about this.
> --- linux-2.6.14-omap2.orig/include/linux/mmc/card.h 2005-12-13 11:41:08.000000000 -0400
> +++ linux-2.6.14-omap2/include/linux/mmc/card.h 2005-12-13 11:42:06.000000000 -0400
> @@ -10,6 +10,7 @@
> #ifndef LINUX_MMC_CARD_H
> #define LINUX_MMC_CARD_H
>
> +#include <linux/key.h>
> #include <linux/mmc/mmc.h>
>
> struct mmc_cid {
> @@ -109,4 +110,6 @@ static inline int mmc_card_claim_host(st
>
> #define mmc_card_release_host(c) mmc_release_host((c)->host)
>
> +extern int mmc_lock_unlock(struct mmc_card *card, struct key *key, int mode);
> +
> #endif
Given that you're not using the contents of struct key, please don't
include <linux/key.h> here - it adds unnecessary include dependencies.
Instead, use a forward declaration:
struct key;
extern int mmc_lock_unlock(struct mmc_card *card, struct key *key, int mode);
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-12-14 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 13:31 [patch 2/5] [RFC] Add MMC password protection (lock/unlock) support Anderson Briglia
2005-12-14 14:28 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051214142804.GB7124@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=briglia.anderson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).