From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix the EMBEDDED menu
Date: Wed, 14 Dec 2005 22:17:03 +0000 [thread overview]
Message-ID: <20051214221702.GH7124@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051214140531.7614152d.akpm@osdl.org>
On Wed, Dec 14, 2005 at 02:05:31PM -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > Hi Linus,
> >
> > your patch to allow CC_OPTIMIZE_FOR_SIZE even for EMBEDDED=n has broken
> > the EMBEDDED menu.
>
> It looks like that patch needs to be reverted or altered anyway. sparc64
> machines are failing all over the place, possibly due to newly-exposed
> compiler bugs.
>
> Whether it's the compiler or it's genuine kernel bugs, the same problems
> are likely to bite other architectures.
I believe there are instances where ARM fails if CC_OPTIMIZE_FOR_SIZE
is not set. Luckily we have assertions in the generated assembly to
flag these as assembly errors when they happen, rather than silently
continuing to build.
Maybe CC_OPTIMIZE_FOR_SIZE should be:
bool "..." if BROKEN || (!ARM && !SPARC64)
? 8)
Note also that the help text:
WARNING: some versions of gcc may generate incorrect code with this
option. If problems are observed, a gcc upgrade may be needed.
is reversed for the situation we have with ARM. Hence, I propose we
change this to something like:
WARNING: some versions of gcc may generate incorrect code if this
option is changed form the platform default. If problems are
observed, either a gcc upgrade may be needed or alternatively
the platform default should be selected (=y for ARM and Sparc64,
n for others.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-12-14 22:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 19:10 [2.6 patch] fix the EMBEDDED menu Adrian Bunk
2005-12-14 22:05 ` Andrew Morton
2005-12-14 22:13 ` [2.6 patch] offer CC_OPTIMIZE_FOR_SIZE only if EXPERIMENTAL Adrian Bunk
2005-12-14 22:18 ` Jesper Juhl
2005-12-14 22:28 ` Jesper Juhl
2005-12-15 0:40 ` Dave Jones
2005-12-15 5:24 ` David S. Miller
2005-12-15 15:01 ` Krzysztof Halasa
2005-12-15 17:35 ` Dave Jones
[not found] ` <7c3341450601191017o796faf45r2cc5c8e544dcfe11@mail.gmail.com>
2006-01-19 19:13 ` Dave Jones
2005-12-15 19:20 ` Denis Vlasenko
2005-12-14 22:22 ` Andrew Morton
2005-12-14 22:26 ` Adrian Bunk
2005-12-14 22:30 ` Russell King
2005-12-14 22:36 ` Linus Torvalds
2005-12-14 22:44 ` Adrian Bunk
2005-12-14 22:46 ` Adrian Bunk
2005-12-14 23:32 ` Linus Torvalds
2005-12-14 23:43 ` Adrian Bunk
2005-12-15 6:45 ` David S. Miller
2005-12-14 23:48 ` David S. Miller
2006-01-19 17:59 ` Eric Lammerts
2005-12-14 22:17 ` Russell King [this message]
2005-12-14 22:24 ` [2.6 patch] fix the EMBEDDED menu Adrian Bunk
2005-12-17 21:20 ` Nicolas Pitre
2005-12-15 13:01 ` Rogério Brito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051214221702.GH7124@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).