linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Grundler <iod00d@hp.com>
To: Mark Maule <maule@sgi.com>
Cc: linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	gregkh@suse.de
Subject: Re: [PATCH 1/3] msi vector targeting abstractions
Date: Tue, 3 Jan 2006 16:20:47 -0800	[thread overview]
Message-ID: <20060104002047.GA14810@esmail.cup.hp.com> (raw)
In-Reply-To: <20060103235024.GC16827@sgi.com>

On Tue, Jan 03, 2006 at 05:50:24PM -0600, Mark Maule wrote:
> > > +struct msi_ops msi_apic_ops = {
> > > +	.setup = msi_setup_apic,
> > > +	.teardown = msi_teardown_apic,
> > > +#ifdef CONFIG_SMP
> > > +	.target = msi_target_apic,
> > > +#endif
> > 
> > Mark,
> > msi_target_apic() initializes address_lo parameter.
> > Even on a UP machine, we need inialize this value.
> 
> Not sure what you mean here.  target is used to retarget an existing
> MSI vector to a different processor.

Right - I didn't realize the caller, set_msi_affinity(), was surrounded by
"#ifdef CONFIG_SMP".

But set_msi_affinity() appears to be dead code.
I couldn't find any calls to set_msi_affinity() in 2.6.14 or 2.6.15.
Greg, you want a patch to remove that?

thanks,
grant

  reply	other threads:[~2006-01-04  0:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-22 20:15 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 20:15 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-03 22:39   ` Grant Grundler
2006-01-03 23:50     ` Mark Maule
2006-01-04  0:20       ` Grant Grundler [this message]
2006-01-04  0:27         ` Greg KH
2006-01-04  3:52           ` Mark Maule
2005-12-22 20:15 ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-04  0:01   ` Grant Grundler
2005-12-22 20:16 ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 20:22 ` [PATCH 0/3] msi abstractions and support for altix Greg KH
2005-12-22 20:26   ` Mark Maule
2005-12-22 20:34     ` Greg KH
2005-12-22 20:38       ` Mark Maule
2005-12-22 20:50         ` Matthew Wilcox
2006-01-03  3:22           ` Mark Maule
2006-01-03  6:07             ` Greg KH
2006-01-10 17:00               ` Mark Maule
2006-01-10 17:03                 ` Christoph Hellwig
2006-01-10 17:11                   ` Greg KH
2005-12-22 21:44         ` Greg KH
2005-12-23 15:32           ` Mark Maule
2005-12-23 16:32             ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2006-03-29  2:31 Mark Maule
2006-03-29  2:31 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 14:34 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-03-21 14:34 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 16:29   ` Jun'ichi Nomura
2006-03-21 16:38     ` Andreas Schwab
2006-03-21 19:14       ` Mark Maule
2006-03-21 19:23         ` Jun'ichi Nomura
2006-03-21 19:38           ` Mark Maule
2006-01-19 19:46 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-19 19:46 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-20  2:15   ` Greg KH
2006-01-11 22:16 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-11 22:16 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 15:52 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-11 15:52 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 20:21   ` Greg KH
2006-01-11 20:49     ` Mark Maule
2006-01-11 20:57       ` Greg KH
2006-01-12  5:02   ` Grant Grundler
2006-01-12  5:36     ` Greg KH
2006-01-12  5:47     ` Paul Mackerras
2006-01-12  7:33       ` Grant Grundler
2005-12-22 17:15 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 17:15 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 19:58   ` Greg KH
2005-12-22 20:09     ` Mark Maule
2005-12-22 20:19       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060104002047.GA14810@esmail.cup.hp.com \
    --to=iod00d@hp.com \
    --cc=gregkh@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=maule@sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).