From: Andrew Morton <akpm@osdl.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: dax@gurulabs.com, erich@areca.com.tw, arjan@infradead.org,
oliver@neukum.org, rlrevell@joe-job.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: ETA for Areca RAID driver (arcmsr) in mainline?
Date: Wed, 4 Jan 2006 01:18:41 -0800 [thread overview]
Message-ID: <20060104011841.036ea510.akpm@osdl.org> (raw)
In-Reply-To: <20051230113227.2b787d43.rdunlap@xenotime.net>
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> Here's a start on some cleanups and a list of general issues.
> I'm not addressing SCSI or MM/DMA API issues, if there are any.
>
> 0. some Kconfig and Makefile cleanups
> 1. fix arcmsr_device_id_table[] inits;
> 2. fix return (value); -- don't use parenethese
> 3. fix one-line-ifs-with-braces -- remove braces
> 4. struct _XYZ & typedef XYZ, PXYZ -- convert to struct XYZ only
> 5. check NULL usage
> 6. no "return;" at end of func; -- removed
> 7. return -ENXIO instead of ENXIO;
>
> Patch for above items is below.
>
> More issues, not yet patched:
>
> 8. check sparse warnings, stack usage, init/exit sections;
> 9. don't use // comments;
> 10. use printk levels
> 11. pPCI_DEV: bad naming (throughout driver; don't use mixed case)
> 12. some comments are unreadable (non-ASCII ?)
> 13. uintNN_t int types: use kernel types except for userspace interfaces
> 14. use kernel-doc
> 15. try to fit source files into 80 columns
Unfortunately I've gone and applied a huge driver update from Erich, so
none of this applies any more.
A recut would be appreciated. Please include your additional suggestions:
16. Tab size in Linux kernel is 8 (not less).
17. Don't put changelog comments in source files. That's what
SCMs are for (source code manager tools).
18. Put arcmsr.txt in Documentation/scsi/, not in scsi/arcmsr/.
19. Maybe use sysfs (/sys) instead of /proc.
In the updated changelog, thanks.
next prev parent reply other threads:[~2006-01-04 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 5:20 ETA for Areca RAID driver (arcmsr) in mainline? Dax Kelson
2005-12-22 5:34 ` Lee Revell
2005-12-22 6:26 ` Dax Kelson
2005-12-22 7:04 ` Lee Revell
2005-12-22 7:24 ` Dax Kelson
2005-12-22 8:17 ` Oliver Neukum
2005-12-22 8:20 ` Arjan van de Ven
2005-12-22 13:24 ` Andrew Morton
2005-12-22 19:31 ` Dax Kelson
2005-12-30 19:32 ` Randy.Dunlap
2005-12-31 5:21 ` [PATCH 2/2] Areca RAID driver (arcmsr) cleanups Randy.Dunlap
2006-01-02 17:04 ` Matthew Wilcox
2006-01-04 9:18 ` Andrew Morton [this message]
2006-01-07 5:17 ` [PATCH] " Randy.Dunlap
2005-12-22 6:43 ` ETA for Areca RAID driver (arcmsr) in mainline? Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104011841.036ea510.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=dax@gurulabs.com \
--cc=erich@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rdunlap@xenotime.net \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).