From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/4] mm: page refcount use atomic primitives
Date: Sun, 8 Jan 2006 13:43:27 -0800 [thread overview]
Message-ID: <20060108134327.63c3afeb.akpm@osdl.org> (raw)
In-Reply-To: <43C178D5.5010703@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> > That's from a two-minute-peek. I haven't thought about this dreadfully
> > hard. But I'd like to gain some confidence that you have, please. This
> > stuff is tricky.
> >
>
> Right, no blam. This is how I avoid taking the LRU lock.
>
> "Instead, use atomic_inc_not_zero to ensure we never **pick up a 0 refcount**
> page from the LRU (ie. we guarantee the page will not be touched)."
>
> I don't understand what you're asking?
Well if you don't understand me, how do you expect me to?
Ho hum. Please redo the patches into something which vaguely applies and
let's give them a spin.
I would prefer that the BUG_ONs be split into a separate patch tho. Or at
least, let's take a real close look at whether they're really needed.
next prev parent reply other threads:[~2006-01-08 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 5:23 [patch 0/4] mm: de-skew page_count Nick Piggin
2006-01-08 5:23 ` [patch 1/4] mm: page refcount use atomic primitives Nick Piggin
2006-01-08 5:54 ` Andrew Morton
2006-01-08 20:40 ` Nick Piggin
2006-01-08 21:43 ` Andrew Morton [this message]
2006-01-08 5:24 ` [patch 2/4] mm: PageLRU no testset Nick Piggin
2006-01-08 5:24 ` [patch 3/4] mm: PageActive " Nick Piggin
2006-01-08 5:25 ` [patch 4/4] mm: less atomic ops Nick Piggin
2006-01-08 5:42 ` [patch 0/4] mm: de-skew page_count Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2006-01-18 10:40 [patch 0/4] mm: de-skew page refcount Nick Piggin
2006-01-18 10:40 ` [patch 1/4] mm: page refcount use atomic primitives Nick Piggin
2005-12-05 11:59 [patch 0/4] mm: optimisations Nick Piggin
2005-12-05 20:43 ` [patch 1/4] mm: page refcount use atomic primitives Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060108134327.63c3afeb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).