From: Greg KH <greg@kroah.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
lkml <linux-kernel@vger.kernel.org>,
Rajesh Shah <rajesh.shah@intel.com>
Subject: Re: [PATCH 1/2]MSI(X) save/restore for suspend/resume
Date: Tue, 10 Jan 2006 12:15:45 -0800 [thread overview]
Message-ID: <20060110201545.GA17908@kroah.com> (raw)
In-Reply-To: <1136422680.30655.1.camel@sli10-desk.sh.intel.com>
On Thu, Jan 05, 2006 at 08:58:00AM +0800, Shaohua Li wrote:
> --- linux-2.6.15-rc5/include/linux/pci.h~msi_save_restore 2005-12-22 09:23:16.000000000 +0800
> +++ linux-2.6.15-rc5-root/include/linux/pci.h 2005-12-22 09:23:16.000000000 +0800
> @@ -135,6 +135,7 @@ struct pci_dev {
> unsigned int block_ucfg_access:1; /* userspace config space access is blocked */
>
> u32 saved_config_space[16]; /* config space saved at suspend time */
> + void *saved_cap_space[PCI_CAP_ID_MAX + 1]; /* ext config space saved at suspend time */
> struct bin_attribute *rom_attr; /* attribute descriptor for sysfs ROM entry */
> int rom_attr_enabled; /* has display of the rom attribute been enabled? */
> struct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */
This should not be a void *, right? Why not make it the proper type?
thanks,
greg k-h
next prev parent reply other threads:[~2006-01-10 20:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 2:05 [PATCH 1/2]MSI(X) save/restore for suspend/resume Shaohua Li
2005-12-27 7:55 ` Arjan van de Ven
2005-12-28 1:24 ` Shaohua Li
2005-12-28 8:25 ` Arjan van de Ven
2005-12-28 8:28 ` Shaohua Li
2006-01-04 7:13 ` Andrew Morton
2006-01-05 0:58 ` Shaohua Li
2006-01-10 20:15 ` Greg KH [this message]
2006-01-10 20:28 ` Matthew Wilcox
2006-01-11 1:17 ` Shaohua Li
2006-01-11 1:26 ` Greg KH
2006-01-11 8:18 ` Shaohua Li
2006-01-11 15:20 ` Matthew Wilcox
2006-01-11 15:51 ` Greg KH
2006-01-11 18:39 ` Matthew Wilcox
2006-01-12 2:30 ` Shaohua Li
2006-01-12 2:47 ` Matthew Wilcox
2006-01-12 3:17 ` Shaohua Li
2006-01-12 7:12 ` Greg KH
2006-02-08 9:11 Shaohua Li
2006-02-21 5:24 ` Greg KH
2006-02-22 8:13 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110201545.GA17908@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).