From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Anderson Briglia <anderson.briglia@indt.org.br>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
linux-kernel@vger.kernel.org,
"Linux-omap-open-source@linux.omap.com"
<linux-omap-open-source@linux.omap.com>,
linux@arm.linux.org.uk, ext David Brownell <david-b@pacbell.net>,
Tony Lindgren <tony@atomide.com>,
"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@indt.org.br>,
"Lizardo Anderson (EXT-INdT/Manaus)"
<anderson.lizardo@indt.org.br>
Subject: Re: [patch 4/5] Add MMC password protection (lock/unlock) support V3
Date: Wed, 11 Jan 2006 14:59:01 +0000 [thread overview]
Message-ID: <20060111145901.GC20523@flint.arm.linux.org.uk> (raw)
In-Reply-To: <43C508E1.4080007@indt.org.br>
On Wed, Jan 11, 2006 at 09:32:17AM -0400, Anderson Briglia wrote:
> Pierre Ossman wrote:
> > Anderson Briglia wrote:
> >
> >
> >>@@ -238,6 +295,11 @@ int mmc_register_card(struct mmc_card *c
> >> if (ret)
> >> device_del(&card->dev);
> >> }
> >>+#ifdef CONFIG_MMC_PASSWORDS
> >>+ ret = device_create_file(&card->dev, &mmc_dev_attr_lockable);
> >>+ if (ret)
> >>+ device_del(&card->dev);
> >>+#endif
> >> }
> >> return ret;
> >>}
> >>
> >>
> >
> >
> > It might be wise to also check the command classes here. I don't believe
> > SDIO supports locking.
>
> In this case, the lockable attribute will show "unlockable", which is
> the expected behavior. The lockable attribute will always be present,
> the card being lockable or not.
"unlockable" seems to be confusing.
"Unlockable" may mean something which is locked but can be unlocked
(unlock-able). Or it may mean something which can't be locked
(un-lockable).
Maybe returning "unsupported", "locked", "unlocked" etc would be
clearer?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-01-11 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 22:16 [patch 4/5] Add MMC password protection (lock/unlock) support V3 Anderson Briglia
2006-01-10 6:46 ` Pierre Ossman
2006-01-11 13:32 ` Anderson Briglia
2006-01-11 14:59 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111145901.GC20523@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=anderson.briglia@indt.org.br \
--cc=anderson.lizardo@indt.org.br \
--cc=carlos.aguiar@indt.org.br \
--cc=david-b@pacbell.net \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).