From: Joerg Sommrey <jo@sommrey.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] amd76x_pm: C2 powersaving for AMD K7
Date: Wed, 11 Jan 2006 18:52:40 +0100 [thread overview]
Message-ID: <20060111175240.GA29857@sommrey.de> (raw)
In-Reply-To: <20060111032057.7569be8a.akpm@osdl.org>
On Wed, Jan 11, 2006 at 03:20:57AM -0800, Andrew Morton wrote:
> Joerg Sommrey <jo@sommrey.de> wrote:
> >
> > +static void
> > +config_amd768_C2(int enable)
> > +{
> > + unsigned char regbyte;
> > +
> > + /* Set C2 options in DevB:3x4F, page 100 in AMD-768 doc */
> > + pci_read_config_byte(pdev_sb, 0x4F, ®byte);
> > + if(enable)
> > + regbyte |= C2EN;
> > + else
> > + regbyte ^= C2EN;
>
> &= ?
This piece of code was not written by me. I agree
regbyte &= ^C2EN;
is more common. However, calling config_amd768_C2(0) *would* work, if
config_amd768_C2(1) had been called before. But config_amd768_C2(0)
never gets called...
Seems like I need to fix this too.
-jo
--
-rw-r--r-- 1 jo users 63 2006-01-10 20:55 /home/jo/.signature
next prev parent reply other threads:[~2006-01-11 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 19:46 [PATCH 1/2] amd76x_pm: C2 powersaving for AMD K7 Joerg Sommrey
2006-01-10 19:50 ` [PATCH 2/2] " Joerg Sommrey
2006-01-11 11:20 ` [PATCH 1/2] " Andrew Morton
2006-01-11 17:52 ` Joerg Sommrey [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-08 19:03 Joerg Sommrey
2006-01-08 19:10 ` Arjan van de Ven
2005-11-04 20:12 Joerg Sommrey
2005-09-01 20:14 Joerg Sommrey
2005-09-05 14:52 ` Pavel Machek
2005-09-05 15:43 ` Tony Lindgren
2005-09-05 20:28 ` Pavel Machek
2005-09-07 7:00 ` Tony Lindgren
2005-09-07 15:18 ` Joerg Sommrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111175240.GA29857@sommrey.de \
--to=jo@sommrey.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).