From: Pavel Machek <pavel@suse.cz>
To: Matt Tolentino <metolent@cs.vt.edu>
Cc: ak@suse.de, akpm@osdl.org, discuss@x86-64.org,
kmannth@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] add __meminit for memory hotplug
Date: Wed, 11 Jan 2006 19:59:58 +0000 [thread overview]
Message-ID: <20060111195958.GE2456@ucw.cz> (raw)
In-Reply-To: <200601091519.k09FJUi3022305@ap1.cs.vt.edu>
On Mon 09-01-06 10:19:30, Matt Tolentino wrote:
> Add __meminit to the __init lineup to ensure functions default
> to __init when memory hotplug is not enabled. Replace __devinit
> with __meminit on functions that were changed when the memory
> hotplug code was introduced.
>
> diff -urNp linux-2.6.15/include/linux/init.h linux-2.6.15-matt/include/linux/init.h
> --- linux-2.6.15/include/linux/init.h 2006-01-02 22:21:10.000000000 -0500
> +++ linux-2.6.15-matt/include/linux/init.h 2006-01-06 11:04:10.000000000 -0500
> @@ -241,6 +241,18 @@ void __init parse_early_param(void);
> #define __cpuexitdata __exitdata
> #endif
>
> +#ifdef CONFIG_MEMORY_HOTPLUG
> +#define __meminit
> +#define __meminitdata
> +#define __memexit
> +#define __memexitdata
You should document these...
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-01-14 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 15:19 [patch 1/2] add __meminit for memory hotplug Matt Tolentino
2006-01-09 15:39 ` Andi Kleen
2006-01-09 18:20 ` Dave Hansen
2006-01-11 19:59 ` Pavel Machek [this message]
2006-01-09 15:48 Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111195958.GE2456@ucw.cz \
--to=pavel@suse.cz \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=kmannth@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=metolent@cs.vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).