From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030237AbWALJqH (ORCPT ); Thu, 12 Jan 2006 04:46:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030240AbWALJqH (ORCPT ); Thu, 12 Jan 2006 04:46:07 -0500 Received: from omx3-ext.sgi.com ([192.48.171.26]:15557 "EHLO omx3.sgi.com") by vger.kernel.org with ESMTP id S1030237AbWALJqG (ORCPT ); Thu, 12 Jan 2006 04:46:06 -0500 Date: Thu, 12 Jan 2006 01:45:51 -0800 From: Paul Jackson To: Russell King Cc: linux-kernel@vger.kernel.org, greg@kroah.com, linux-ia64@vger.kernel.org Subject: Re: [CFT 9/29] Add tiocx bus_type probe/remove methods Message-Id: <20060112014551.8e7888c3.pj@sgi.com> In-Reply-To: <20060105142951.13.09@flint.arm.linux.org.uk> References: <20060105142951.13.01@flint.arm.linux.org.uk> <20060105142951.13.09@flint.arm.linux.org.uk> Organization: SGI X-Mailer: Sylpheed version 2.1.7 (GTK+ 2.4.9; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This patch looks broken. I see the lines: + .remove = cx_device_remove, - cx_driver->driver.remove = cx_driver_remove; The routine (not in this patch) is still known as "cx_driver_remove" but now it is linked to from the .remove line as "cx_device_remove" A defconfig ia64 build of *-mm3 with this patch fails: arch/ia64/sn/kernel/tiocx.c:151: error: `cx_device_remove' undeclared here (not in a function) arch/ia64/sn/kernel/tiocx.c:151: error: initializer element is not constant arch/ia64/sn/kernel/tiocx.c:151: error: (near initialization for `tiocx_bus_type.remove') arch/ia64/sn/kernel/tiocx.c:137: warning: `cx_driver_remove' defined but not used When I s/cx_device_remove/cx_driver_remove/, then ia64 *-mm3 defconfig builds fine. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401