linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, sct@redhat.com, mingo@elte.hu
Subject: Re: 2.6.15-git7 oopses in ext3 during LTP runs II - more problems
Date: Thu, 12 Jan 2006 01:55:26 +0100	[thread overview]
Message-ID: <200601120155.26679.ak@suse.de> (raw)
In-Reply-To: <1137014875.2929.81.camel@laptopd505.fenrus.org>

On Wednesday 11 January 2006 22:27, Arjan van de Ven wrote:
> > 15/fs/ext3/super.c~	2006-01-11 21:54:13.000000000 +0100
> > > +++ linux-2.6.15/fs/ext3/super.c	2006-01-11 21:54:13.000000000 +0100
> > > @@ -2150,7 +2150,7 @@
> > >  
> > >  static void ext3_write_super (struct super_block * sb)
> > >  {
> > > -	if (mutex_trylock(&sb->s_lock) != 0)
> > > +	if (!mutex_trylock(&sb->s_lock) != 0)
> > >  		BUG();
> > >  	sb->s_dirt = 0;
> > >  }
> > 
> > We expect the lock to be held on entry.  Hence we expect mutex_trylock()
> > to return zero.
> 
> you are correct, and the x86-64 mutex.h is buggy

While this patch seemed  to fix LTP my desktop running the same kernel (with 
mutex fix) hung the mailer while sending an unrelated mail. Again on ext3.

I unfortunately don't have the backtraces anymore because I couldn't
save them to disk before the reboot (and forgot to copy them
to another system sorry), but they were also hanging in some JBD/ext3
functions in D, with all disk accesses hanging.

So things appear to be still broken in ext3 land.

-Andi


  parent reply	other threads:[~2006-01-12  0:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-11 20:26 2.6.15-git7 oopses in ext3 during LTP runs Andi Kleen
2006-01-11 20:46 ` Andrew Morton
2006-01-11 20:55   ` Arjan van de Ven
2006-01-11 21:07     ` Andrew Morton
2006-01-11 21:27       ` Arjan van de Ven
2006-01-11 22:19         ` Ingo Molnar
2006-01-11 22:40         ` Pavel Machek
2006-01-11 22:44           ` David S. Miller
2006-01-12  0:30             ` Ingo Molnar
2006-01-11 22:47           ` Jesper Juhl
2006-01-12  8:51             ` Pavel Machek
2006-01-12  0:55         ` Andi Kleen [this message]
2006-01-12  1:14           ` 2.6.15-git7 oopses in ext3 during LTP runs II - more problems Andrew Morton
2006-01-12  1:25             ` Andi Kleen
2006-01-11 21:25     ` 2.6.15-git7 oopses in ext3 during LTP runs Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601120155.26679.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).