From: Andi Kleen <ak@suse.de>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: akpm@osdl.org, rdreier@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64
Date: Thu, 12 Jan 2006 05:45:34 +0100 [thread overview]
Message-ID: <200601120545.34711.ak@suse.de> (raw)
In-Reply-To: <1137040361.29795.8.camel@camp4.serpentine.com>
On Thursday 12 January 2006 05:32, Bryan O'Sullivan wrote:
> On Thu, 2006-01-12 at 05:19 +0100, Andi Kleen wrote:
> > My feeling is more and more that this thing is so specialized for your
> > setup and so narrow purpose that you're best off dropping this whole
> > patchkit and just put the assembly into your driver.
>
> But this gave people fits when Roland first posted the driver for
> review.
Yah, but they clearly didn't see the whole picture back then
(you should probably have explained it better). All the ugly details
were only brought to light on close review.
> There's also no clean, obvious way to make it work on other
> 64-bit architectures, in that case.
for loop and writel() ?
-Andi
next prev parent reply other threads:[~2006-01-12 4:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 0:29 [PATCH 0 of 2] Much smaller MMIO copy patches Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 1 of 2] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64 Bryan O'Sullivan
2006-01-12 0:56 ` Andi Kleen
2006-01-12 1:21 ` Roland Dreier
2006-01-12 1:27 ` Andi Kleen
2006-01-12 1:32 ` Roland Dreier
2006-01-12 1:40 ` Andi Kleen
2006-01-12 1:27 ` Bryan O'Sullivan
2006-01-12 1:33 ` Andi Kleen
2006-01-12 4:14 ` Bryan O'Sullivan
2006-01-12 4:19 ` Andi Kleen
2006-01-12 4:32 ` Bryan O'Sullivan
2006-01-12 4:45 ` Andi Kleen [this message]
2006-01-12 5:04 ` Bryan O'Sullivan
2006-01-12 15:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601120545.34711.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).