linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: Reuben Farrelly <reuben-lkml@reub.net>,
	Andrew Morton <akpm@osdl.org>,
	neilb@suse.de, mingo@elte.hu, linux-kernel@vger.kernel.org,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: 2.6.15-mm2
Date: Thu, 12 Jan 2006 09:22:27 +0100	[thread overview]
Message-ID: <20060112082227.GG17718@suse.de> (raw)
In-Reply-To: <20060112080051.GA22783@htj.dyndns.org>

On Thu, Jan 12 2006, Tejun Heo wrote:
> Hello, Reuben, Jens and all.
> 
> On Thu, Jan 12, 2006 at 04:49:30PM +1300, Reuben Farrelly wrote:
> > 
> > 
> > On 12/01/2006 8:53 a.m., Jens Axboe wrote:
> > >On Wed, Jan 11 2006, Jens Axboe wrote:
> > >>At least it shows that the problem is indeed barrier related. I don't
> > >>have the start of this thread, so can you please send me the output from
> > >>dmesg from this kernel boot? I'm curious whether the fallback triggers,
> > >>or if it's the barrier that fails instead.
> > >
> > >Or even better, please boot with this patch applied on top of the kernel
> > >you just booted (the new one, with the md patch applied).
> > >
> > >diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> > >index 4c5127e..07aee66 100644
> > >--- a/drivers/scsi/sd.c
> > >+++ b/drivers/scsi/sd.c
> > >@@ -1492,6 +1492,7 @@ static int sd_revalidate_disk(struct gen
> > > 		ordered = QUEUE_ORDERED_DRAIN;
> > > 
> > > 	blk_queue_ordered(sdkp->disk->queue, ordered, sd_prepare_flush);
> > >+	printk("%s: ordered set to %d\n", disk->disk_name, ordered);
> > > 
> > > 	set_capacity(disk, sdkp->capacity);
> > > 	kfree(buffer);
> > 
> > Here it is...
> > 
> > Linux version 2.6.15-mm3 (root@tornado.reub.net) (gcc version 4.1.0 
> > 20060106 (Red Hat 4.1.0-0.14)) #4 SMP Thu Jan 12 16:26:28 NZDT 2006
> [--snip--]
> > ahci 0000:00:1f.2: AHCI 0001.0000 32 slots 4 ports 1.5 Gbps 0xf impl SATA 
> > mode
> > ahci 0000:00:1f.2: flags: 64bit ncq led slum part
> > ata1: SATA max UDMA/133 cmd 0xF8804D00 ctl 0x0 bmdma 0x0 irq 193
> > ata2: SATA max UDMA/133 cmd 0xF8804D80 ctl 0x0 bmdma 0x0 irq 193
> > ata3: SATA max UDMA/133 cmd 0xF8804E00 ctl 0x0 bmdma 0x0 irq 193
> > ata4: SATA max UDMA/133 cmd 0xF8804E80 ctl 0x0 bmdma 0x0 irq 193
> > ata1: SATA link up 1.5 Gbps (SStatus 113)
> > ata1: dev 0 cfg 49:2f00 82:346b 83:7d01 84:4003 85:3469 86:3c01 87:4003 
> > 88:007f
> > ata1: dev 0 ATA-6, max UDMA/133, 156301488 sectors: LBA48
> > ata1: dev 0 configured for UDMA/133
> > scsi0 : ahci
> > ata2: SATA link up 1.5 Gbps (SStatus 113)
> > ata2: dev 0 cfg 49:2f00 82:346b 83:7d01 84:4003 85:3469 86:3c01 87:4003 
> > 88:007f
> > ata2: dev 0 ATA-6, max UDMA/133, 156301488 sectors: LBA48
> > ata2: dev 0 configured for UDMA/133
> > scsi1 : ahci
> > ata3: SATA link up 1.5 Gbps (SStatus 113)
> > ata3: dev 0 cfg 49:2f00 82:346b 83:7d01 84:4003 85:3469 86:3c01 87:4003 
> > 88:007f
> > ata3: dev 0 ATA-6, max UDMA/133, 156299375 sectors: LBA48
> > ata3: dev 0 configured for UDMA/133
> > scsi2 : ahci
> > ata4: SATA link down (SStatus 0)
> > scsi3 : ahci
> >   Vendor: ATA       Model: ST380817AS        Rev: 3.42
> >   Type:   Direct-Access                      ANSI SCSI revision: 05
> >   Vendor: ATA       Model: ST380817AS        Rev: 3.42
> >   Type:   Direct-Access                      ANSI SCSI revision: 05
> >   Vendor: ATA       Model: ST380013AS        Rev: 3.18
> >   Type:   Direct-Access                      ANSI SCSI revision: 05
> > SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB)
> > sda: Write Protect is off
> > sda: Mode Sense: 00 3a 00 00
> > SCSI device sda: drive cache: write back
> > sda: ordered set to 49
> 
> 49d == 31h == QUEUE_ORDERED_DRAIN_FLUSH which is the right ordered
> mode on most SATA drives.  Barrier is performed by
> 
>  drain -> pre-flush -> barrier -> post-flush
> 
> sequence.  If something went wrong and above sequence got stuck, the
> first suspect part would be 'draining'.  I'm attaching a patch which
> adds a bunch of debug messages regarding ordered sequencing.  Can you
> please apply the patch and post the log message?  The patch is against
> v2.6.15-mm2.
> 
> I've also tested almost the same setup here - 2 maxtor SATA drives
> hanging off AHCI and grouped into /dev/md0 and it works fine here.  It
> prints something like the following while mounting /dev/md0 on boot
> with the debug patch applied.

It works fine for me as well, both with SATA using the drain-flush
approach and with SCSI + FUA _and_ drain-flush (modified SD to set that
instead).

Thanks for looking at this Tejun, we badly need it fixed asap!

-- 
Jens Axboe


  reply	other threads:[~2006-01-12  8:20 UTC|newest]

Thread overview: 133+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07 13:22 2.6.15-mm2 Andrew Morton
2006-01-07 13:23 ` 2.6.15-mm2 Andrew Morton
2006-01-07 15:05 ` 2.6.15-mm2 Reuben Farrelly
2006-01-07 21:31   ` 2.6.15-mm2 Andrew Morton
2006-01-07 22:06     ` 2.6.15-mm2 Reuben Farrelly
2006-01-07 23:15       ` 2.6.15-mm2 Reuben Farrelly
2006-01-07 23:40         ` 2.6.15-mm2 Andrew Morton
2006-01-10 10:15     ` 2.6.15-mm2 Reuben Farrelly
2006-01-10 10:30       ` 2.6.15-mm2 Andrew Morton
2006-01-10 10:58         ` 2.6.15-mm2 Reuben Farrelly
2006-01-10 10:47       ` 2.6.15-mm2 Ingo Molnar
2006-01-10 10:52         ` 2.6.15-mm2 Ingo Molnar
2006-01-10 10:58           ` 2.6.15-mm2 Ingo Molnar
2006-01-10 11:34           ` 2.6.15-mm2 Ingo Molnar
2006-01-10 12:28         ` 2.6.15-mm2 Reuben Farrelly
2006-01-10 12:42           ` 2.6.15-mm2 Andrew Morton
2006-01-10 13:16             ` 2.6.15-mm2 Ingo Molnar
2006-01-11  4:16               ` 2.6.15-mm2 Neil Brown
2006-01-11  5:15                 ` 2.6.15-mm2 Reuben Farrelly
2006-01-11  5:30                   ` 2.6.15-mm2 Andrew Morton
2006-01-11  5:30                     ` 2.6.15-mm2 Andrew Morton
2006-01-11 10:49                       ` 2.6.15-mm2 Reuben Farrelly
2006-01-11 11:05                         ` 2.6.15-mm2 Andrew Morton
2006-01-11 11:13                           ` 2.6.15-mm2 Jens Axboe
2006-01-11 11:40                             ` 2.6.15-mm2 Reuben Farrelly
2006-01-11 11:56                               ` 2.6.15-mm2 Jens Axboe
2006-01-11 14:39                                 ` 2.6.15-mm2 Reuben Farrelly
2006-01-11 14:52                                   ` 2.6.15-mm2 Jens Axboe
2006-01-11 14:55                                     ` 2.6.15-mm2 Jens Axboe
2006-01-11 19:23                                       ` 2.6.15-mm2 Reuben Farrelly
2006-01-11 19:45                                         ` 2.6.15-mm2 Jens Axboe
2006-01-11 19:53                                           ` 2.6.15-mm2 Jens Axboe
2006-01-12  3:49                                             ` 2.6.15-mm2 Reuben Farrelly
2006-01-12  8:00                                               ` 2.6.15-mm2 Tejun Heo
2006-01-12  8:22                                                 ` Jens Axboe [this message]
     [not found]                                                 ` <43C61598.7050004@reub.net>
2006-01-12 11:18                                                   ` 2.6.15-mm2 Tejun Heo
2006-01-12 12:05                                                     ` 2.6.15-mm2 Reuben Farrelly
2006-01-12 12:31                                                       ` 2.6.15-mm2 Ric Wheeler
2006-01-12 12:39                                                         ` 2.6.15-mm2 Reuben Farrelly
2006-01-12 13:55                                                           ` 2.6.15-mm2 Tejun Heo
2006-01-12 14:10                                                             ` 2.6.15-mm2 Jens Axboe
2006-01-12 14:20                                                               ` 2.6.15-mm2 Tejun Heo
2006-01-12 19:26                                                             ` 2.6.15-mm2 Reuben Farrelly
2006-01-12 20:32                                                               ` 2.6.15-mm2 Andrew Morton
2006-01-12 20:51                                                                 ` 2.6.15-mm2 Jeff Garzik
2006-01-13  4:49                                                                   ` 2.6.15-mm2 Reuben Farrelly
2006-01-11 21:44                                 ` 2.6.15-mm2 Neil Brown
2006-01-12  7:35                                   ` 2.6.15-mm2 Jens Axboe
2006-01-07 15:08 ` 2.6.15-mm2 Jesper Juhl
2006-01-09 17:47   ` 2.6.15-mm2 Jesper Juhl
2006-01-09 17:57     ` 2.6.15-mm2 Dave Jones
2006-01-09 18:01       ` 2.6.15-mm2 Jesper Juhl
2006-01-09 18:24         ` 2.6.15-mm2 Hugh Dickins
2006-01-09 18:48           ` 2.6.15-mm2 Jesper Juhl
2006-01-09 19:16             ` 2.6.15-mm2 Hugh Dickins
2006-01-09 19:21               ` 2.6.15-mm2 Hugh Dickins
2006-01-09 19:39               ` 2.6.15-mm2 Jesper Juhl
2006-01-09 20:15                 ` 2.6.15-mm Hugh Dickins
2006-01-09 20:30                   ` 2.6.15-mm Jesper Juhl
2006-01-09 20:41                     ` 2.6.15-mm Hugh Dickins
2006-01-09 20:46                       ` [PATCH] fix Jesper's sg_page_free Bad page states Hugh Dickins
2006-01-09 20:44                   ` 2.6.15-mm Mike Christie
2006-01-09 21:04                     ` 2.6.15-mm Hugh Dickins
2006-01-07 16:20 ` 2.6.15-mm2: why is __get_page_state() global again? Adrian Bunk
2006-01-07 18:00 ` [-mm patch] drivers/block/amiflop.c: fix compilation Adrian Bunk
2006-01-07 18:19 ` [-mm patch] drivers/acpi/: make two functions static Adrian Bunk
2006-01-07 18:21 ` [-mm patch] kernel/synchro-test.c: make 5 " Adrian Bunk
2006-01-07 19:31 ` 2.6.15-mm2 Brice Goglin
2006-01-07 21:04   ` 2.6.15-mm2 Dave Jones
2006-01-07 21:26     ` 2.6.15-mm2 Brice Goglin
2006-01-07 21:29       ` 2.6.15-mm2 David S. Miller
2006-01-07 21:41       ` 2.6.15-mm2 Arjan van de Ven
2006-01-07 21:42       ` 2.6.15-mm2 Dave Jones
2006-01-07 21:50         ` 2.6.15-mm2 Brice Goglin
2006-01-07 22:13           ` 2.6.15-mm2 Dave Jones
2006-01-07 22:26             ` 2.6.15-mm2 Brice Goglin
2006-01-11 18:41       ` 2.6.15-mm2 Brice Goglin
2006-01-11 20:29         ` 2.6.15-mm2 Dave Jones
2006-01-11 21:50           ` 2.6.15-mm2 Dave Airlie
2006-01-11 21:56             ` 2.6.15-mm2 Dave Jones
2006-01-11 23:50               ` 2.6.15-mm2 Dave Airlie
2006-01-12 10:58           ` 2.6.15-mm2 Ulrich Mueller
2006-01-12 17:11             ` 2.6.15-mm2 Dave Jones
2006-01-12 18:11               ` 2.6.15-mm2 Ulrich Mueller
2006-01-12 20:37                 ` 2.6.15-mm2 Dave Airlie
2006-01-12 21:03                   ` 2.6.15-mm2 Alan Hourihane
2006-01-12 22:02                     ` 2.6.15-mm2 Dave Airlie
2006-01-13  8:32                       ` 2.6.15-mm2 Alan Hourihane
2006-01-13 16:49                         ` 2.6.15-mm2 Dave Jones
2006-01-12 19:12               ` 2.6.15-mm2 Brice Goglin
2006-01-12 19:21                 ` 2.6.15-mm2 Dave Jones
2006-01-07 22:58   ` 2.6.15-mm2 Andrew Morton
2006-01-07 23:38     ` 2.6.15-mm2 Brice Goglin
2006-01-08 12:24       ` 2.6.15-mm2 Andrew Morton
2006-01-08 14:39         ` 2.6.15-mm2 Brice Goglin
2006-01-08 18:56           ` 2.6.15-mm2 Andrew Morton
2006-01-08 12:28       ` 2.6.15-mm2 Andrew Morton
2006-01-08 14:14         ` 2.6.15-mm2 Brice Goglin
2006-01-07 20:51 ` Badness in __mutex_unlock_slowpath Andrew James Wade
2006-01-07 21:13   ` Arjan van de Ven
2006-01-08  8:53     ` Ingo Molnar
2006-01-07 21:06 ` 2.6.15-mm2: alpha broken Alexey Dobriyan
2006-01-07 23:48   ` Andrew Morton
2006-01-08  0:45     ` [PATCH -mm] fixup *at syscalls additions (alpha, sparc64) Alexey Dobriyan
2006-01-08  0:54     ` [PATCH -mm] Fixup arch/alpha/mm/init.c compilation Alexey Dobriyan
2006-01-08 12:31     ` 2.6.15-mm2: alpha broken Alexey Dobriyan
2006-01-11  2:24     ` Paul Jackson
2006-01-13 14:11       ` Adrian Bunk
2006-01-13 15:52         ` Paul Jackson
2006-01-13 16:37         ` Al Viro
2006-01-13 18:10         ` Paul Jackson
2006-01-13 18:19           ` Randy.Dunlap
2006-01-13 19:05             ` Thomas Gleixner
2006-01-13 21:08             ` Adrian Bunk
2006-01-13 21:12               ` Randy.Dunlap
2006-01-13 21:32                 ` Adrian Bunk
2006-01-13 21:52                   ` Paul Jackson
2006-01-13 22:18                     ` Andrew Morton
2006-01-13 19:26           ` Andrew Morton
2006-01-13 21:05           ` Adrian Bunk
2006-01-08  0:40 ` 2.6.15-mm2 Alexander Gran
     [not found] ` <200601080139.34774@zodiac.zodiac.dnsalias.org>
     [not found]   ` <20060107175056.3d7a2895.akpm@osdl.org>
2006-01-10  0:30     ` 2.6.15-mm2 Alexander Gran
2006-01-10  1:22       ` 2.6.15-mm2 Andrew Morton
2006-01-10 21:20 ` 2.6.15-mm2 Serge E. Hallyn
2006-01-07 21:51 2.6.15-mm2 Chuck Ebbert
2006-01-07 22:01 2.6.15-mm2 Chuck Ebbert
2006-01-08  8:16 2.6.15-mm2 Brown, Len
2006-01-08 14:23 ` 2.6.15-mm2 Brice Goglin
2006-01-08  8:19 2.6.15-mm2 Brown, Len
2006-01-08  9:40 ` 2.6.15-mm2 Reuben Farrelly
2006-01-08 17:58 2.6.15-mm2 Brown, Len
2006-01-08 18:08 2.6.15-mm2 Brown, Len
2006-01-08 18:18 2.6.15-mm2 Brown, Len

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060112082227.GG17718@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=neilb@suse.de \
    --cc=reuben-lkml@reub.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).