linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Hugh Dickins <hugh@veritas.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] fix i386 mutex fastpath on FRAME_POINTER &&  !DEBUG_MUTEXES
Date: Thu, 12 Jan 2006 12:53:08 -0500	[thread overview]
Message-ID: <200601121256_MC3-1-B5C3-FDE0@compuserve.com> (raw)

In-Reply-To: <Pine.LNX.4.58.0601110511590.24014@devserv.devel.redhat.com>

On Wed, 11 Jan 2006, Ingo Molnar wrote:

> On Wed, 11 Jan 2006, Chuck Ebbert wrote:
>
> > 
> >                 LOCK    "   decl (%%eax)        \n"                     \
> >                         "   jns 1f              \n"                     \
> >                         "   call "#fail_fn"     \n"                     \
> >                         "1:                     \n"                     \
> >                                                                         \
> >                 :"=a" (dummy)                                           \
> >                 : "a" (count)                                           \
> > 
> > 
> > Will the extra taken forward conditional jump in the fastpath cause much
> > of a slowdown?
> 
> yeah - the fastpath is much more common than the slowpath.

But that's how the spinlock code does it.  Should that be changed to put the
spinloops in .text.lock and make the fastpaths a fall-through?

-- 
Chuck
Currently reading: _Olympos_ by Dan Simmons

             reply	other threads:[~2006-01-12 17:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-12 17:53 Chuck Ebbert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-11  8:24 [patch] fix i386 mutex fastpath on FRAME_POINTER && !DEBUG_MUTEXES Chuck Ebbert
2006-01-11 10:13 ` Ingo Molnar
2006-01-10 17:44 i386 FRAME_POINTER needs DEBUG_MUTEXES Hugh Dickins
2006-01-10 21:07 ` [patch] fix i386 mutex fastpath on FRAME_POINTER && !DEBUG_MUTEXES Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601121256_MC3-1-B5C3-FDE0@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).