From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161321AbWALVrf (ORCPT ); Thu, 12 Jan 2006 16:47:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161322AbWALVrf (ORCPT ); Thu, 12 Jan 2006 16:47:35 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:30621 "EHLO e31.co.us.ibm.com") by vger.kernel.org with ESMTP id S1161321AbWALVre (ORCPT ); Thu, 12 Jan 2006 16:47:34 -0500 Date: Thu, 12 Jan 2006 15:47:19 -0600 From: Jon Mason To: Muli Ben-Yehuda Cc: Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware Message-ID: <20060112214719.GE17539@us.ibm.com> References: <20060112175051.GA17539@us.ibm.com> <43C6ADDE.5060904@liberouter.org> <20060112200735.GD5399@granada.merseine.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060112200735.GD5399@granada.merseine.nu> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2006 at 10:07:35PM +0200, Muli Ben-Yehuda wrote: > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote: > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this, > > which will be removed soon, I guess. And, additionally, could you change that > > lines to use PCI_DEVICE macro? > > This driver is not up for removal soon, as it supports a device that > the alsa driver apparently doesn't (the INTERG_5050). As for > PCI_DEVICE, agreed. Jon, feel like patching it up? Patches to follow. After looking at the ALSA driver, it doesn't support PCI IDs for ALI_5451 or CYBER5050. Someone should look into porting any necessary code from sound/oss/trident.c to sound/pci/trident/trident.c Thanks, Jon